Skip to content

Commit

Permalink
docs: add <webview> 'did-attach' event documentation (#30129)
Browse files Browse the repository at this point in the history
Co-authored-by: Milan Burda <milan.burda@gmail.com>
  • Loading branch information
trop[bot] and miniak committed Jul 15, 2021
1 parent 6d0feb8 commit 52cddbc
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 0 deletions.
4 changes: 4 additions & 0 deletions docs/api/webview-tag.md
Expand Up @@ -718,6 +718,10 @@ Corresponds to the points in time when the spinner of the tab starts spinning.

Corresponds to the points in time when the spinner of the tab stops spinning.

### Event: 'did-attach'

Fired when attached to the embedder web contents.

### Event: 'dom-ready'

Fired when document in the given frame is loaded.
Expand Down
20 changes: 20 additions & 0 deletions spec-main/webview-spec.ts
Expand Up @@ -184,6 +184,26 @@ describe('<webview> tag', function () {
});
});

describe('did-attach event', () => {
it('is emitted when a webview has been attached', async () => {
const w = new BrowserWindow({
webPreferences: {
webviewTag: true
}
});
await w.loadURL('about:blank');
const message = await w.webContents.executeJavaScript(`new Promise((resolve, reject) => {
const webview = new WebView()
webview.setAttribute('src', 'about:blank')
webview.addEventListener('did-attach', (e) => {
resolve('ok')
})
document.body.appendChild(webview)
})`);
expect(message).to.equal('ok');
});
});

describe('did-change-theme-color event', () => {
it('emits when theme color changes', async () => {
const w = new BrowserWindow({
Expand Down

0 comments on commit 52cddbc

Please sign in to comment.