Skip to content

Commit

Permalink
chore: improve renderer crash logging (#25621)
Browse files Browse the repository at this point in the history
Co-authored-by: Milan Burda <milan.burda@gmail.com>
  • Loading branch information
trop[bot] and miniak committed Sep 24, 2020
1 parent e964c1e commit 4a0f2be
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions lib/browser/api/web-contents.js
Expand Up @@ -468,8 +468,7 @@ const addReturnValueToEvent = (event) => {
};

const loggingEnabled = () => {
return Object.prototype.hasOwnProperty.call(process.env, 'ELECTRON_ENABLE_LOGGING') ||
process.argv.some(arg => arg.toLowerCase().startsWith('--enable-logging'));
return process.env.ELECTRON_ENABLE_LOGGING || app.commandLine.hasSwitch('enable-logging');
};

// Add JavaScript wrappers for WebContents class.
Expand Down Expand Up @@ -538,17 +537,17 @@ WebContents.prototype._init = function () {

this.on('crashed', (event, ...args) => {
app.emit('renderer-process-crashed', event, this, ...args);
});

this.on('render-process-gone', (event, details) => {
app.emit('render-process-gone', event, this, details);

// Log out a hint to help users better debug renderer crashes.
if (loggingEnabled()) {
console.info('Renderer process crashed - see https://www.electronjs.org/docs/tutorial/application-debugging for potential debugging information.');
console.info(`Renderer process ${details.reason} - see https://www.electronjs.org/docs/tutorial/application-debugging for potential debugging information.`);
}
});

this.on('render-process-gone', (event, ...args) => {
app.emit('render-process-gone', event, this, ...args);
});

// The devtools requests the webContents to reload.
this.on('devtools-reload-page', function () {
this.reload();
Expand Down

0 comments on commit 4a0f2be

Please sign in to comment.