fix: showing certificate dialog with no window (#24121)

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
electron · Jun 13, 2020 · 496b0f8 · 496b0f8
1 parent 0d80baf
commit 496b0f8
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/browser/api/dialog.js b/lib/browser/api/dialog.js
@@ -249,7 +249,11 @@ module.exports = {
   },
 
   showCertificateTrustDialog: function (window, options) {
-    if (window && window.constructor !== BrowserWindow) options = window;
+    if (window && window.constructor !== BrowserWindow) {
+      options = window;
+      window = null;
+    }
+
     if (options == null || typeof options !== 'object') {
       throw new TypeError('options must be an object');
     }