Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch '13-x-y' into cherry-pick/13-x-y/v8/014e1f857c33
- Loading branch information
Showing
4 changed files
with
87 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
patches/chromium/disable_quictransport_explicitly_in_the_network_service.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | ||
From: Victor Vasiliev <vasilvv@chromium.org> | ||
Date: Tue, 26 Oct 2021 04:50:35 +0000 | ||
Subject: Disable QuicTransport explicitly in the Network Service | ||
|
||
(cherry picked from commit b1997bdadcda9738a19773f82605f65832acedac) | ||
|
||
Bug: 1260940 | ||
Change-Id: I6689fbce8115eda19e68414d7c03691704749b17 | ||
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3242207 | ||
Auto-Submit: Victor Vasiliev <vasilvv@chromium.org> | ||
Commit-Queue: Yutaka Hirano <yhirano@chromium.org> | ||
Reviewed-by: Yutaka Hirano <yhirano@chromium.org> | ||
Cr-Commit-Position: refs/branch-heads/4606@{#1411} | ||
Cr-Branched-From: 35b0d5a9dc8362adfd44e2614f0d5b7402ef63d0-refs/heads/master@{#911515} | ||
|
||
diff --git a/services/network/quic_transport.cc b/services/network/quic_transport.cc | ||
index df262796d9021ed478e1154e1f327ac51fe5885e..27fe2b4d2ab9f77b7d68afac57bde6b3b4d7f8e0 100644 | ||
--- a/services/network/quic_transport.cc | ||
+++ b/services/network/quic_transport.cc | ||
@@ -27,7 +27,7 @@ net::WebTransportParameters CreateParameters( | ||
const std::vector<mojom::QuicTransportCertificateFingerprintPtr>& | ||
fingerprints) { | ||
net::WebTransportParameters params; | ||
- params.enable_quic_transport = true; | ||
+ params.enable_quic_transport = false; | ||
params.enable_web_transport_http3 = true; | ||
|
||
for (const auto& fingerprint : fingerprints) { | ||
diff --git a/services/network/quic_transport_unittest.cc b/services/network/quic_transport_unittest.cc | ||
index ecb4f81e4ad947275dcdb1bcdfba1d3295947322..10ff49baaabdc1fce54376fd01ebde8f10c6f9d3 100644 | ||
--- a/services/network/quic_transport_unittest.cc | ||
+++ b/services/network/quic_transport_unittest.cc | ||
@@ -359,7 +359,7 @@ struct PrintStringPiece { | ||
|
||
INSTANTIATE_TEST_SUITE_P(QuicTransportTests, | ||
QuicTransportTest, | ||
- testing::Values("quic-transport", "https"), | ||
+ testing::Values("https"), | ||
PrintStringPiece()); | ||
|
||
TEST_P(QuicTransportTest, ConnectSuccessfully) { | ||
@@ -671,7 +671,7 @@ class QuicTransportWithCustomCertificateTest : public QuicTransportTest { | ||
|
||
INSTANTIATE_TEST_SUITE_P(QuicTransportWithCustomCertificateTests, | ||
QuicTransportWithCustomCertificateTest, | ||
- testing::Values("quic-transport", "https"), | ||
+ testing::Values("https"), | ||
PrintStringPiece()); | ||
|
||
TEST_P(QuicTransportWithCustomCertificateTest, WithValidFingerprint) { |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | ||
From: Toon Verwaest <verwaest@chromium.org> | ||
Date: Wed, 27 Oct 2021 11:02:06 +0200 | ||
Subject: Merged: [runtime] Check if we have a pending exception before | ||
returning it | ||
|
||
Revision: be55c16e50e714475034b00ed2682f0813794d15 | ||
|
||
BUG=chromium:1263462 | ||
NOTRY=true | ||
NOPRESUBMIT=true | ||
NOTREECHECKS=true | ||
R=cbruni@chromium.org | ||
|
||
Change-Id: Ib7de676fe614403674fcd2745c574f7e91ded23f | ||
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3247033 | ||
Reviewed-by: Camillo Bruni <cbruni@chromium.org> | ||
Cr-Commit-Position: refs/branch-heads/9.4@{#52} | ||
Cr-Branched-From: 3b51863bc25492549a8bf96ff67ce481b1a3337b-refs/heads/9.4.146@{#1} | ||
Cr-Branched-From: 2890419fc8fb9bdb507fdd801d76fa7dd9f022b5-refs/heads/master@{#76233} | ||
|
||
diff --git a/src/execution/isolate-inl.h b/src/execution/isolate-inl.h | ||
index 96ea770e65b48dbecf7422b49ef4f8d2f0cfe2d0..3486925aed54f03db13554763a6146134e83d2bb 100644 | ||
--- a/src/execution/isolate-inl.h | ||
+++ b/src/execution/isolate-inl.h | ||
@@ -35,7 +35,7 @@ NativeContext Isolate::raw_native_context() { | ||
} | ||
|
||
Object Isolate::pending_exception() { | ||
- DCHECK(has_pending_exception()); | ||
+ CHECK(has_pending_exception()); | ||
DCHECK(!thread_local_top()->pending_exception_.IsException(this)); | ||
return thread_local_top()->pending_exception_; | ||
} |