Skip to content

Commit

Permalink
fix: remove accidental revert of crashpad_pid_check.patch
Browse files Browse the repository at this point in the history
  • Loading branch information
richard-townsend-arm committed Aug 26, 2019
1 parent 54fdc5d commit 3a1b8e7
Showing 1 changed file with 0 additions and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -176,24 +176,3 @@ sK;|$p7y(IpXGq97LjukL7RU|`k&Y1ou8yJc&i;NOt`Q*)4h~Ta0HmRmk^lez
literal 0
HcmV?d00001

diff --git a/third_party/crashpad/crashpad/util/win/exception_handler_server.cc b/third_party/crashpad/crashpad/util/win/exception_handler_server.cc
index e89b8ff675bed2fa65263ea451d40995e0b010b7..2593ff2de0327c393c30cae9962a329c5e27b64e 100644
--- a/third_party/crashpad/crashpad/util/win/exception_handler_server.cc
+++ b/third_party/crashpad/crashpad/util/win/exception_handler_server.cc
@@ -448,16 +448,9 @@ bool ExceptionHandlerServer::ServiceClientConnection(
DWORD real_pid = 0;
if (get_named_pipe_client_process_id(service_context.pipe(), &real_pid) &&
message.registration.client_process_id != real_pid) {
- // Electron: When both browser process and renderer process are connecting
- // to the pipe, the API may return the PID of browser process as real_pid,
- // which is different from the PID of renderer process.
- //
- // I don't understand why Chromium does not have this issue.
-#if 0
LOG(ERROR) << "forged client pid, real pid: " << real_pid
<< ", got: " << message.registration.client_process_id;
return false;
-#endif
}
}

0 comments on commit 3a1b8e7

Please sign in to comment.