Skip to content

Commit

Permalink
test: make a few tests hide their windows (#25466)
Browse files Browse the repository at this point in the history
  • Loading branch information
zcbenz committed Sep 15, 2020
1 parent 45170fd commit 2091fd7
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions spec-main/chromium-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ describe('web security', () => {
});

it('engages CORB when web security is not disabled', async () => {
const w = new BrowserWindow({ show: true, webPreferences: { webSecurity: true, nodeIntegration: true } });
const w = new BrowserWindow({ show: false, webPreferences: { webSecurity: true, nodeIntegration: true } });
const p = emittedOnce(ipcMain, 'success');
await w.loadURL(`data:text/html,<script>
const s = document.createElement('script')
Expand All @@ -236,7 +236,7 @@ describe('web security', () => {
});

it('bypasses CORB when web security is disabled', async () => {
const w = new BrowserWindow({ show: true, webPreferences: { webSecurity: false, nodeIntegration: true } });
const w = new BrowserWindow({ show: false, webPreferences: { webSecurity: false, nodeIntegration: true } });
const p = emittedOnce(ipcMain, 'success');
await w.loadURL(`data:text/html,
<script>
Expand All @@ -247,7 +247,7 @@ describe('web security', () => {
});

it('does not crash when multiple WebContent are created with web security disabled', () => {
const options = { webPreferences: { webSecurity: false } };
const options = { show: false, webPreferences: { webSecurity: false } };
const w1 = new BrowserWindow(options);
w1.loadURL(serverUrl);
const w2 = new BrowserWindow(options);
Expand Down

0 comments on commit 2091fd7

Please sign in to comment.