Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't trim null notes #46

Merged
merged 1 commit into from Aug 31, 2020
Merged

fix: don't trim null notes #46

merged 1 commit into from Aug 31, 2020

Conversation

codebytere
Copy link
Member

Closes #44.

Fixes an issue where we would call notes.trim() with a notes value of null, which throws.

cc @jkleinsc @MarshallOfSound @nornagon

@codebytere codebytere changed the title fix: don't trim null fix: don't trim null notes Aug 31, 2020
@codebytere codebytere merged commit 04fc9c3 into master Aug 31, 2020
@codebytere codebytere deleted the null-fix branch August 31, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release notes status is sometimes not reported
2 participants
@codebytere @MarshallOfSound