Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release notes status is sometimes not reported #44

Closed
codebytere opened this issue Aug 31, 2020 · 0 comments · Fixed by #46
Closed

Release notes status is sometimes not reported #44

codebytere opened this issue Aug 31, 2020 · 0 comments · Fixed by #46
Assignees
@codebytere
Labels
bug Something isn't working

Comments

@codebytere
Copy link
Member

codebytere commented Aug 31, 2020 •
edited

In some multi-line release notes, the release notes status is sometimes not reported.

electron/electron#25219.

This appears to happen when there is a newline between Notes: and the bullet list. The check resolves when the newline is removed.
@codebytere codebytere added the bug Something isn't working label Aug 31, 2020
@codebytere codebytere changed the title Release notes check never resolves Release notes status is sometimes not reported Aug 31, 2020
@codebytere codebytere mentioned this issue Aug 31, 2020
Merged
@codebytere codebytere self-assigned this Aug 31, 2020
@codebytere codebytere mentioned this issue Aug 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codebytere codebytere

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't trim null notes electron/clerk
1 participant
@codebytere