Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use e --help when testing usability of e #13

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Mar 19, 2022

I believe this is needed as a result of electron/build-tools#336. Looks like now a bare e invocation will have an exit code of 1, which does seem to be more standard behavior (same as git, open, and other bare commands that show help). However that means execSync chokes on it since it's coming back as an error, so switch to using e --help instead in this test.

@codebytere codebytere merged commit 100d16e into electron:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants