Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow riscv64 support via custom electron dist #8143

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mmaietta
Copy link
Collaborator

Original contributor @kxxt in #7646

Added throwing error when riscv64 binary is not provided via electronDist configuration function or string path

Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: a5d721d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
app-builder-lib Major
builder-util Major
electron-builder Major
dmg-builder Major
electron-builder-squirrel-windows Major
electron-forge-maker-appimage Major
electron-forge-maker-nsis-web Major
electron-forge-maker-nsis Major
electron-forge-maker-snap Major
electron-publish Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit a5d721d
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/65f9d86cd7c63e0008e51d48
😎 Deploy Preview https://deploy-preview-8143--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta
Copy link
Collaborator Author

@kxxt, interested in giving this upcoming release a try with the support of riscv64 implementation in electron-builder?

@kxxt
Copy link

kxxt commented Mar 20, 2024

@kxxt, interested in giving this upcoming release a try with the support of riscv64 implementation in electron-builder?

Thanks a lot for bring this up again! Previously I only tested it on riscv64. Today I tested packaging for riscv64 on x86_64 and found one thing I missed: 6ba54e3

@mmaietta
Copy link
Collaborator Author

I'll add that in.

I got your app-builder PR merged in and released develar/app-builder#90 into 5.0.0-alpha.0
We're still blocked on that upgrade in PR due to build issues #8139 so I'll ping you again once that's released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants