Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add customUnWelcomePage macro for nsis #7790

Merged
merged 2 commits into from
Sep 25, 2023
Merged

feat: add customUnWelcomePage macro for nsis #7790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22e79f9
feat: add customUnWelcomePage macro
xianyunleo Sep 22, 2023
2f80547
Create real-planets-float.md
mmaietta Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/real-planets-float.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
"app-builder-lib": minor
---

feat: add customUnWelcomePage macro for NSIS installers
8 changes: 7 additions & 1 deletion docs/configuration/nsis.md
View file
Open in desktop
Expand Up @@ -37,7 +37,7 @@ Two options are available — [include](#NsisOptions-include) and [script](#Nsis
Keep in mind — if you customize NSIS script, you should always state about it in the issue reports. And don't expect that your issue will be resolved.

1. Add file `build/installer.nsh`.
2. Define wanted macro to customise: `customHeader`, `preInit`, `customInit`, `customUnInit`, `customInstall`, `customUnInstall`, `customRemoveFiles`, `customInstallMode`, `customWelcomePage`.
2. Define wanted macro to customise: `customHeader`, `preInit`, `customInit`, `customUnInit`, `customInstall`, `customUnInstall`, `customRemoveFiles`, `customInstallMode`, `customWelcomePage`, `customUnWelcomePage`.

!!! example
```nsis
Expand Down Expand Up @@ -67,6 +67,12 @@ Keep in mind — if you customize NSIS script, you should always state about it
# Welcome Page is not added by default for installer.
!insertMacro MUI_PAGE_WELCOME
!macroend

!macro customUnWelcomePage
!define MUI_WELCOMEPAGE_TITLE "custom title for uninstaller welcome page"
!define MUI_WELCOMEPAGE_TEXT "custom text for uninstaller welcome page $\r$\n more"
!insertmacro MUI_UNPAGE_WELCOME
!macroend
```

* `BUILD_RESOURCES_DIR` and `PROJECT_DIR` are defined.
Expand Down
7 changes: 6 additions & 1 deletion packages/app-builder-lib/templates/nsis/assistedInstaller.nsh
View file
Open in desktop
Expand Up @@ -64,7 +64,12 @@
!endif
!else
!ifndef removeDefaultUninstallWelcomePage
!insertmacro MUI_UNPAGE_WELCOME
!ifmacrodef customUnWelcomePage
!insertmacro customUnWelcomePage
!else
!insertmacro MUI_UNPAGE_WELCOME
!endif

!endif
!ifndef INSTALL_MODE_PER_ALL_USERS
!insertmacro PAGE_INSTALL_MODE
Expand Down