Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use osslsigncode in a vm #7275

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

Mstrodl
Copy link
Contributor

@Mstrodl Mstrodl commented Nov 21, 2022

We were running into an issue where windows builds on osx were trying to use osslsigncode in our parallels VM rather than signtool

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2022

🦋 Changeset detected

Latest commit: 93edd51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Nov 21, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 93edd51
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/637bd2aff545a60008ce059e
😎 Deploy Preview https://deploy-preview-7275--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Mstrodl Mstrodl changed the title windowsCodeSign: don't use osslsigncode in a vm! Don't use osslsigncode in a vm! Nov 21, 2022
@Mstrodl Mstrodl changed the title Don't use osslsigncode in a vm! Don't use osslsigncode in a vm Nov 21, 2022
@Mstrodl Mstrodl changed the title Don't use osslsigncode in a vm fix: don't use osslsigncode in a vm Nov 21, 2022
@mmaietta mmaietta merged commit 5668dc2 into electron-userland:master Nov 22, 2022
@github-actions github-actions bot mentioned this pull request Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants