Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get CI tag in GitHub Actions #7231

Merged

Conversation

laprasdrum
Copy link
Contributor

@laprasdrum laprasdrum commented Nov 2, 2022

fixes #7066

If we use getCiTag() on GitHub Actions, we should return GITHUB_REF_NAME.
https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2022

🦋 Changeset detected

Latest commit: c7c0f68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
electron-publish Patch
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Nov 2, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit c7c0f68
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/636293355ad2a80008589895
😎 Deploy Preview https://deploy-preview-7231--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta mmaietta merged commit c21e3b3 into electron-userland:master Nov 2, 2022
@laprasdrum laprasdrum deleted the get-ci-tag-from-gh-actions branch November 3, 2022 00:24
@github-actions github-actions bot mentioned this pull request Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github actions tag
2 participants