Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly configure electron-rebuild for monorepos #7215

Merged
merged 4 commits into from
Oct 26, 2022

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Oct 25, 2022

Using electron-rebuild for finding project root for native node addons in order to handle monorepo setups

Fixes: #7212

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022

🦋 Changeset detected

Latest commit: 509b008

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 509b008
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/63595e6eecf17500090a1898
😎 Deploy Preview https://deploy-preview-7215--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta mmaietta marked this pull request as ready for review October 26, 2022 16:21
@mmaietta mmaietta merged commit 0d3b87f into master Oct 26, 2022
@mmaietta mmaietta deleted the fix/install-app-deps-monorepo branch October 26, 2022 16:45
@github-actions github-actions bot mentioned this pull request Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native dependencies are not built when using yarn workspaces in 24.0.0-alpha.1
1 participant