Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update note for pnpm #7163

Merged
merged 1 commit into from Oct 3, 2022
Merged

Conversation

romadryud
Copy link
Contributor

It will more clear to developer to see that note in electron-builder docs. This line was taken from pnpm docs

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2022

⚠️ No Changeset found

Latest commit: 379b761

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 28, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 379b761
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/633aa203d58a760008ae3338
😎 Deploy Preview https://deploy-preview-7163--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@romadryud romadryud changed the title update note for pnpm feat: update note for pnpm Sep 28, 2022
@romadryud
Copy link
Contributor Author

@develar Could you please take a look on this tiny one?

@mmaietta
Copy link
Collaborator

Great callout.
Can you please also edit the PNPM note on the Readme as part of this PR?
https://github.com/electron-userland/electron-builder/blob/master/README.md#note-for-pnpm

@romadryud
Copy link
Contributor Author

@mmaietta Done ✅

@mmaietta mmaietta merged commit b9e78f2 into electron-userland:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants