New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: non-silent mode allow not to run the app when the installation is complete #7136
Conversation
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
🦋 Changeset detectedLatest commit: 5fd2b5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Mike, I refined code to avoid creating a new function that is basically duplicated code of the other function and breaking change previous functionality. Please review. |
@shenglianlee that seems much better 🙂 |
@mmaietta I tried to generate the docs but getting the following error while running Log``` $ pnpm generate-all
Generating JSDoc to D:\electron-builder\scripts\jsdoc\out\builder-util-runtime
|
That's weird. I'll give it a shot locally to update the schema before releasing a new version |
Currently method quitAndInstall only in silent installation mode allows user to set "isForceRunAfter" value to decide whether to run the installed application. Actually sometimes in non-silent installation mode, the user does not want to run the installed application after the installation is complete. In order to avoid breaking change previous functionality I add new method quitAppAndInstall , it's will quit the app and explicit installs the update and allows to set "isForceRunAfter" value to decide whether to run the installed application.