Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: non-silent mode allow not to run the app when the installation is complete #7136

Merged
merged 3 commits into from Oct 1, 2022

Conversation

shenglianlee
Copy link
Contributor

Currently method quitAndInstall only in silent installation mode allows user to set "isForceRunAfter" value to decide whether to run the installed application. Actually sometimes in non-silent installation mode, the user does not want to run the installed application after the installation is complete. In order to avoid breaking change previous functionality I add new method quitAppAndInstall , it's will quit the app and explicit installs the update and allows to set "isForceRunAfter" value to decide whether to run the installed application.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 5fd2b5a
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/633709d0034f110008c1502e
😎 Deploy Preview https://deploy-preview-7136--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2022

🦋 Changeset detected

Latest commit: 5fd2b5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shenglianlee
Copy link
Contributor Author

Mike, I refined code to avoid creating a new function that is basically duplicated code of the other function and breaking change previous functionality. Please review.

@shenglianlee shenglianlee changed the title feat: add new method quitAppAndInstall. feat: non-silent mode allow not to run the app when the installation is complete Sep 26, 2022
@mmaietta
Copy link
Collaborator

@shenglianlee that seems much better 🙂
Since we're adding a new config option, can you please regenerate schema? pnpm generate-all

@shenglianlee
Copy link
Contributor Author

@mmaietta I tried to generate the docs but getting the following error while running pnpm generate-all.
I upgraded node from 12.14.1 to 14.19.1 but still get the same result. :(

Log ``` $ pnpm generate-all

@electron-builder/monorepo@ generate-all D:\electron-builder
pnpm generate-schema && pnpm generate-docs && pnpm prettier

@electron-builder/monorepo@ generate-schema D:\electron-builder
typescript-json-schema packages/app-builder-lib/tsconfig-scheme.json Configuration --out packages/app-builder-lib/scheme.json --noExtraProps --useTypeOfKeyword --strictNullChecks --required && node ./scripts/fix-schema.js

@electron-builder/monorepo@ generate-docs D:\electron-builder
pnpm compile && pnpm jsdoc && pnpm jsdoc2md2html

@electron-builder/monorepo@ compile D:\electron-builder
tsc --build

@electron-builder/monorepo@ jsdoc D:\electron-builder
ts2jsdoc packages/builder-util-runtime packages/builder-util packages/app-builder-lib packages/electron-builder packages/electron-publish packages/electron-updater packages/dmg-builder

Generating JSDoc to D:\electron-builder\scripts\jsdoc\out\builder-util-runtime
Generating JSDoc to D:\electron-builder\scripts\jsdoc\out\publisher
exception evaluating "{ ...this.packager.platformSpecificBuildOptions, ...(this.packager.config as any)[this.name] }" for property options
exception evaluating "{
...this.packager.platformSpecificBuildOptions,
...(this.packager.config as any)[this.name],
}" for property options
exception evaluating "{ ...this.packager.platformSpecificBuildOptions, ...(this.packager.config as any)[this.name] }" for property options
exception evaluating "{ ...this.packager.platformSpecificBuildOptions, ...(this.packager.config as any)[this.name] }" for property options
exception evaluating "{
allowAnywhere: true,
allowCurrentUserHome: true,
allowRootDirectory: true,
...this.packager.config.pkg,
}" for property options
Generating JSDoc to D:\electron-builder\scripts\jsdoc\out\builder-lib
Generating JSDoc to D:\electron-builder\scripts\jsdoc\out\util
Generating JSDoc to D:\electron-builder\scripts\jsdoc\out\updater
Generating JSDoc to D:\electron-builder\scripts\jsdoc\out\builder
exception evaluating "this.packager.config.dmg || Object.create(null)" for property options
Generating JSDoc to D:\electron-builder\scripts\jsdoc\out\dmg-builder
Error: ENOENT: no such file or directory, open 'D:\electron-builder\scripts\jsdoc\out\builder-lib\app-builder-lib-out-asar\asar.js'
at processImmediate (internal/timers.js:464:21)
From previous event:
at transpilePaths (D:\electron-builder\node_modules.pnpm\ts-jsdoc@3.2.2_typescript@4.3.5\node_modules\ts-jsdoc\src\util.ts:15:26)
at Object.transpile (D:\electron-builder\node_modules.pnpm\ts-jsdoc@3.2.2_typescript@4.3.5\node_modules\ts-jsdoc\src\util.ts:11:10)
at Object. (D:\electron-builder\node_modules.pnpm\ts-jsdoc@3.2.2_typescript@4.3.5\node_modules\ts-jsdoc\src\ts2jsdoc.ts:9:1)
at Module._compile (internal/modules/cjs/loader.js:1085:14)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
at Module.load (internal/modules/cjs/loader.js:950:32)
at Function.Module._load (internal/modules/cjs/loader.js:790:12)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:75:12)
at internal/main/run_main_module.js:17:47
 ELIFECYCLE  Command failed with exit code 4294967295.
 ELIFECYCLE  Command failed with exit code 1.
 ELIFECYCLE  Command failed with exit code 1.

</details>

@mmaietta mmaietta merged commit 4d989a8 into electron-userland:master Oct 1, 2022
@mmaietta
Copy link
Collaborator

mmaietta commented Oct 1, 2022

That's weird. I'll give it a shot locally to update the schema before releasing a new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants