Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Invalid code signing for MAS build (#7040) #7089

Merged
merged 4 commits into from Aug 28, 2022
Merged

fix: Invalid code signing for MAS build (#7040) #7089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
098bbc6
fix: invalid code signing for MAS build
jeanfbrito Aug 25, 2022
bcabfa3
Create violet-comics-cover.md
mmaietta Aug 25, 2022
85be1af
Delete `;`
jeanfbrito Aug 25, 2022
0c40d3e
Merge branch 'fix/mas-code-signing' of https://github.com/jeanfbrito/…
jeanfbrito Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/violet-comics-cover.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
"app-builder-lib": patch
---

fix: Swaps order of Apple certificate selection to fix publishing the MAS package on Mac Apple Store. (#7040)
2 changes: 1 addition & 1 deletion packages/app-builder-lib/src/macPackager.ts
View file
Open in desktop
Expand Up @@ -468,5 +468,5 @@ function getCertificateTypes(isMas: boolean, isDevelopment: boolean): CertType[]
if (isDevelopment) {
return isMas ? ["Mac Developer", "Apple Development"] : ["Mac Developer", "Developer ID Application"]
}
return isMas ? ["3rd Party Mac Developer Application", "Apple Distribution"] : ["Developer ID Application"]
return isMas ? ["Apple Distribution", "3rd Party Mac Developer Application"] : ["Developer ID Application"]
}