fix: use `buildVersion` not `buildNumber` for fpm `--iteration` flag #7075

davej · 2022-08-19T12:21:52Z

buildNumber is not overridable in the config and is provided directly by the CI, this should be buildVersion instead.

Dashes are not supported for iteration in some versions of fpm, so I replaced dashes with underscores. jordansissel/fpm#1833

Also, the linter complained, so I fixed up the type definition for the use function.

…lectron-userland#6945) `buildNumber` is not overridable in the config and is provided directly by the CI, this should be `buildVersion` instead. Dashes are not supported for iteration in some versions of fpm, so replace with underscores. jordansissel/fpm#1833

changeset-bot · 2022-08-19T12:21:55Z

🦋 Changeset detected

Latest commit: 2ea46e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
app-builder-lib	Minor
electron-builder	Minor
builder-util	Minor
dmg-builder	Minor
electron-builder-squirrel-windows	Minor
electron-forge-maker-appimage	Minor
electron-forge-maker-nsis-web	Minor
electron-forge-maker-nsis	Minor
electron-forge-maker-snap	Minor
electron-publish	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify · 2022-08-19T12:21:56Z

✅ Deploy Preview for car-park-attendant-cleat-11576 ready!

Name	Link
🔨 Latest commit	`2ea46e4`
🔍 Latest deploy log	https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/630807de216f05000894b4e6
😎 Deploy Preview	https://deploy-preview-7075--car-park-attendant-cleat-11576.netlify.app/configuration/configuration
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sandeep1995 · 2022-08-20T10:37:11Z

Tested. Works well.

davej · 2022-08-22T10:00:48Z

Fixed a few more lint errors. All tests/lints should pass now.

mmaietta · 2022-08-23T00:59:43Z

I'm pretty sure this is a breaking change. I rely on buildNumber to be used for --iteration as well. Or rather I set the env var manually. It comes from here:

electron-builder/packages/app-builder-lib/src/appInfo.ts

Lines 42 to 55 in 369f1fa

    
           this.buildNumber = 
        
             process.env.BUILD_NUMBER || 
        
             process.env.TRAVIS_BUILD_NUMBER || 
        
             process.env.APPVEYOR_BUILD_NUMBER || 
        
             process.env.CIRCLE_BUILD_NUM || 
        
             process.env.BUILD_BUILDNUMBER || 
        
             process.env.CI_PIPELINE_IID 
        
           if (buildVersion == null) { 
        
             buildVersion = this.version 
        
             if (!isEmptyOrSpaces(this.buildNumber)) { 
        
               buildVersion += `.${this.buildNumber}` 
        
             } 
        
           } 
        
           this.buildVersion = buildVersion

Why can't we retain current behavior? Why not just allow overriding with metadata.buildVersion in the package.json or electron-builder config file? Similar to this but for buildNumber

electron-builder/packages/app-builder-lib/src/appInfo.ts

Line 64 in 369f1fa

    
           this.productName = info.config.productName || info.metadata.productName || info.metadata.name!

davej · 2022-08-23T11:16:18Z

@mmaietta yes, technically it would be a breaking change. I'm not sure there are any real-world scenarios where this might cause real-world issues though? I assumed this was a bug as buildNumber isn't used directly by any other distribution formats, only fpm. fpm doesn't seem to use buildVersion anywhere either (like other formats do).

Why not just allow overriding with metadata.buildVersion in the package.json or electron-builder config file?

Isn't that pretty close to what we're doing in this PR? If buildVersion is explicitly defined then --iteration will be ${buildVersion}. If buildVersion isn't defined then --iteration will be ${version}.${buildNumber} (with buildNumber defined by the env var).

That's my thinking on it but I'm happy to proceed with whatever direction you think makes sense.

Unrelated to this PR but one final note about buildNumber: the envs it uses aren't always just build numbers. In my case (Azure Pipelines), it leaked the associated commit message and email address. It's unlikely that the env var will have sensitive information in it but it's just something to be aware of.

mmaietta · 2022-08-23T16:13:39Z

one final note about buildNumber: the envs it uses aren't always just build numbers. In my case (Azure Pipelines), it leaked the associated commit message and email address.

Hmmm That, by definition, is not a build number. I'm not sure how to solve for that edge case as it doesn't seem normal. We can add a way to override via metadata or config, but even that could be considered a breaking change

davej · 2022-08-23T17:03:42Z

@mmaietta how do you want me to proceed? I'm happy to make whatever changes you think are reasonable. The main thing that I want to do is fix #6945, everything else is just a personal preference.

I guess the minimal changeset for that would be to just add it.split("-").join("_") to the --iteration param. Even this would technically be a breaking change but if the --iteration "number" had a dash then the build would have failed . We could go a step further and do more aggressive sanitization of the string and just allow alphanumerics, periods (.) and underscores (_) because I'm not actually sure if other characters will break the build.

If we want to do a non-breaking change then I guess we just add a buildNumber to the config that will take precedence over any env vars if it is explicitly defined. You mentioned that this is a breaking change above but I'm not sure what you mean? Do you mean that the user may have provided a buildNumber config option even though it isn't used by electron-builder?

mmaietta · 2022-08-23T22:13:41Z

If we want to do a non-breaking change then I guess we just add a buildNumber to the config that will take precedence over any env vars if it is explicitly defined.

This sounds perfect. Something like this below, but you may need to make other edits for the buildNumber property to be available. Not sure if it's accessible via config either

this.buildNumber = info.config.buildNumber || info.metadata.buildNumber ||
      process.env.BUILD_NUMBER ||
      ..... // the other env vars

Note, I'm fully in favor of this fix as it also helps remove some workarounds I made in my own project :)

…userland#6945) explicit `buildNumber` will take precedence over any envs

davej · 2022-08-23T23:38:37Z

@mmaietta Thanks! I've made the requested changes. Let me know if I'm missing anything.

mmaietta · 2022-08-25T13:59:54Z

Looks good. Can you please add a changeset for this PR via pnpm generate-changeset? That way it gets auto-picked up by the release automation.

mmaietta · 2022-08-25T14:51:13Z

packages/app-builder-lib/src/configuration.ts

@@ -129,9 +129,15 @@ export interface Configuration extends PlatformSpecificBuildOptions {
   */
  readonly npmRebuild?: boolean

+  /**
+   * The build number. Maps to the `--iteration` flag for builds using FPM on Linux.
+   * If not defined then will fallback to `BUILD_NUMBER` or `TRAVIS_BUILD_NUMBER` or `APPVEYOR_BUILD_NUMBER` or `CIRCLE_BUILD_NUM` or `BUILD_BUILDNUMBER` or `CI_PIPELINE_IID` env.


Minor grammar change (comma + 'it'): "If not defined, then it will fallback"

Thanks for also specifying its relationship to --iteration

mmaietta · 2022-08-25T14:53:07Z

packages/app-builder-lib/src/configuration.ts

  /**
   * The build version. Maps to the `CFBundleVersion` on macOS, and `FileVersion` metadata property on Windows. Defaults to the `version`.
-   * If `TRAVIS_BUILD_NUMBER` or `APPVEYOR_BUILD_NUMBER` or `CIRCLE_BUILD_NUM` or `BUILD_NUMBER` or `bamboo.buildNumber` or `CI_PIPELINE_IID` env defined, it will be used as a build version (`version.build_number`).
+   * If `buildVersion` is not defined and `buildNumber` (or one of the `buildNumber envs) is defined, it will be used as a build version (`version.buildNumber`).


"`buildNumber envs" is missing a closing backtick around buildNumber

You'll need to re-run pnpm generate-all after adjusting these jsdocs

mmaietta · 2022-08-25T14:54:04Z

packages/app-builder-lib/src/targets/fpm.ts

+        "--iteration",
+        // dashes are not supported for iteration in older versions of fpm
+        // https://github.com/jordansissel/fpm/issues/1833
+        it.split("-").join("_")


Change to it.replaceAll('-', '_')

replaceAll isn't supported in Node 14.

davej · 2022-08-25T15:18:24Z

@mmaietta Getting the following error while running pnpm generate-all:

Error log

``` ➜ electron-builder git:(fix/fpm-iteration) ✗ pnpm generate-all

@electron-builder/monorepo@ generate-all /Users/davejeffery/code/forks/electron-builder
pnpm generate-schema && pnpm generate-docs && pnpm prettier

@electron-builder/monorepo@ generate-schema /Users/davejeffery/code/forks/electron-builder
typescript-json-schema packages/app-builder-lib/tsconfig-scheme.json Configuration --out packages/app-builder-lib/scheme.json --noExtraProps --useTypeOfKeyword --strictNullChecks --required && node ./scripts/fix-schema.js

/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/appInfo.ts (1,38): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/asar/asarFileChecker.ts (1,28): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/asar/asarUtil.ts (1,39): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/asar/asarUtil.ts (2,55): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/asar/unpackDetector.ts (2,21): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/asar/unpackDetector.ts (3,29): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/binDownload.ts (1,35): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/codesign.ts (5,43): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/codesign.ts (6,28): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/macCodeSign.ts (2,105): Cannot find module 'builder-util/out/util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/macCodeSign.ts (3,42): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/macCodeSign.ts (4,32): Cannot find module 'builder-util/out/log' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/macCodeSign.ts (92,15): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/macCodeSign.ts (97,104): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/macCodeSign.ts (124,110): Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
Type 'undefined' is not assignable to type 'string'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/macCodeSign.ts (128,66): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/macCodeSign.ts (131,12): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/macCodeSign.ts (135,15): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/macCodeSign.ts (149,68): Parameter 'e' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/macCodeSign.ts (239,67): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/macCodeSign.ts (243,19): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/macCodeSign.ts (252,88): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/macCodeSign.ts (335,16): Object is possibly 'undefined'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/codeSign/windowsCodeSign.ts (1,57): Cannot find module 'builder-util/out/util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/configuration.ts (1,22): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/core.ts (1,48): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/core.ts (2,35): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/electron/ElectronFramework.ts (2,49): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/electron/ElectronFramework.ts (3,89): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/electron/electronMac.ts (2,82): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/electron/electronMac.ts (3,48): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/electron/electronMac.ts (177,47): Parameter 'protocol' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/electron/electronVersion.ts (1,48): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/electron/electronVersion.ts (2,26): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/electron/electronVersion.ts (3,30): Cannot find module 'builder-util/out/nodeHttpExecutor' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/fileMatcher.ts (2,30): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/fileMatcher.ts (3,94): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/fileMatcher.ts (53,43): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/fileTransformer.ts (1,40): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/fileTransformer.ts (2,33): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/fileTransformer.ts (33,10): Parameter 'file' implicitly has an 'any' type.
packages/app-builder-lib/src/Framework.ts (1,33): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/frameworks/LibUiFramework.ts (4,35): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/index.ts (1,32): Cannot find module 'builder-util/out/promise' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/index.ts (2,32): Cannot find module 'electron-publish/out/publisher' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/index.ts (3,48): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/index.ts (4,25): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/index.ts (24,53): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/index.ts (49,49): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/index.ts (50,44): Cannot find module 'electron-publish' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/index.ts (107,34): Parameter 'isErrorOccurred' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/linuxPackager.ts (1,45): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/macPackager.ts (2,110): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/macPackager.ts (7,54): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/macPackager.ts (8,34): Cannot find module 'builder-util/out/promise' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/macPackager.ts (429,86): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/options/CommonWindowsInstallerConfiguration.ts (1,60): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/options/CommonWindowsInstallerConfiguration.ts (78,111): Argument of type 'string | null | undefined' is not assignable to parameter of type 'string'.
Type 'undefined' is not assignable to type 'string'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/packager.ts (1,167): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/packager.ts (2,35): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/packager.ts (3,54): Cannot find module 'builder-util/out/promise' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/packager.ts (9,37): Cannot find module 'builder-util/out/arch' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/packager.ts (370,17): Property 'file' does not exist on type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/packager.ts (371,33): Property 'file' does not exist on type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/packagerApi.ts (1,22): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/packagerApi.ts (2,38): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/packagerApi.ts (7,28): Cannot find module 'electron-publish' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/platformPackager.ts (2,156): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/platformPackager.ts (3,60): Cannot find module 'builder-util/out/arch' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/platformPackager.ts (4,45): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/platformPackager.ts (5,34): Cannot find module 'builder-util/out/promise' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/platformPackager.ts (99,14): Object is possibly 'null' or 'undefined'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/platformPackager.ts (126,7): Argument of type '{ file: string; safeArtifactName: string | null | undefined; target: Target | null; arch: any; packager: this; }' is not assignable to parameter of type 'ArtifactCreated'.
Object literal may only specify known properties, and 'file' does not exist in type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/platformPackager.ts (393,52): Parameter 'file' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/presets/rectCra.ts (1,21): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/presets/rectCra.ts (2,28): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/ProtonFramework.ts (1,33): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/ProtonFramework.ts (2,21): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/ProtonFramework.ts (3,35): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/ProtonFramework.ts (52,13): Parameter 'file' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/BitbucketPublisher.ts (1,71): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/BitbucketPublisher.ts (2,30): Cannot find module 'builder-util/out/nodeHttpExecutor' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/BitbucketPublisher.ts (4,47): Cannot find module 'electron-publish' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/BitbucketPublisher.ts (5,34): Cannot find module 'builder-util-runtime/out/publishOptions' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/BitbucketPublisher.ts (6,55): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/BitbucketPublisher.ts (54,96): Property 'context' does not exist on type 'BitbucketPublisher'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/BitbucketPublisher.ts (54,123): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/BitbucketPublisher.ts (65,88): Property 'context' does not exist on type 'BitbucketPublisher'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/KeygenPublisher.ts (1,71): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/KeygenPublisher.ts (2,30): Cannot find module 'builder-util/out/nodeHttpExecutor' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/KeygenPublisher.ts (4,47): Cannot find module 'electron-publish' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/KeygenPublisher.ts (5,31): Cannot find module 'builder-util-runtime/out/publishOptions' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/KeygenPublisher.ts (6,66): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/KeygenPublisher.ts (98,27): Object is possibly 'undefined'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/KeygenPublisher.ts (145,88): Property 'context' does not exist on type 'KeygenPublisher'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/KeygenPublisher.ts (181,100): Property 'context' does not exist on type 'KeygenPublisher'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/KeygenPublisher.ts (219,96): Property 'context' does not exist on type 'KeygenPublisher'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/KeygenPublisher.ts (253,97): Property 'context' does not exist on type 'KeygenPublisher'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/KeygenPublisher.ts (266,88): Property 'context' does not exist on type 'KeygenPublisher'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/PublishManager.ts (2,149): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/PublishManager.ts (14,8): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/PublishManager.ts (16,81): Cannot find module 'electron-publish' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/PublishManager.ts (17,33): Cannot find module 'electron-publish/out/gitHubPublisher' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/PublishManager.ts (18,31): Cannot find module 'electron-publish/out/multiProgress' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/PublishManager.ts (180,116): Property 'arch' does not exist on type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/PublishManager.ts (186,29): Property 'file' does not exist on type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/PublishManager.ts (197,35): Property 'file' does not exist on type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/BaseS3Publisher.ts (1,40): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/BaseS3Publisher.ts (2,31): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/BaseS3Publisher.ts (3,55): Cannot find module 'electron-publish' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/BaseS3Publisher.ts (24,36): Property 'context' does not exist on type 'BaseS3Publisher'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/BaseS3Publisher.ts (39,10): Property 'createProgressBar' does not exist on type 'BaseS3Publisher'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/BaseS3Publisher.ts (49,51): Parameter 'resolve' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/BaseS3Publisher.ts (49,60): Parameter 'reject' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/BaseS3Publisher.ts (49,68): Parameter 'onCancel' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/BaseS3Publisher.ts (50,31): Parameter 'process' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/BaseS3Publisher.ts (57,40): Property 'providerName' does not exist on type 'BaseS3Publisher'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/BaseS3Publisher.ts (67,20): Property 'providerName' does not exist on type 'BaseS3Publisher'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/s3Publisher.ts (1,67): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/s3Publisher.ts (2,27): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/s3Publisher.ts (3,32): Cannot find module 'electron-publish' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/spacesPublisher.ts (1,60): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/spacesPublisher.ts (2,31): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/spacesPublisher.ts (3,32): Cannot find module 'electron-publish' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/spacesPublisher.ts (46,30): Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
Type 'undefined' is not assignable to type 'string'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/s3/spacesPublisher.ts (47,30): Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
Type 'undefined' is not assignable to type 'string'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/SnapStorePublisher.ts (1,55): Cannot find module 'electron-publish' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/SnapStorePublisher.ts (2,35): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/SnapStorePublisher.ts (4,34): Cannot find module 'builder-util-runtime/out/publishOptions' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/SnapStorePublisher.ts (14,10): Property 'createProgressBar' does not exist on type 'SnapStorePublisher'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/updateInfoBuilder.ts (2,63): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/updateInfoBuilder.ts (3,91): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/updateInfoBuilder.ts (102,96): Property 'arch' does not exist on type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/updateInfoBuilder.ts (109,54): Property 'file' does not exist on type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/updateInfoBuilder.ts (144,62): Property 'file' does not exist on type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/updateInfoBuilder.ts (150,92): Property 'arch' does not exist on type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/updateInfoBuilder.ts (171,35): Property 'file' does not exist on type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/updateInfoBuilder.ts (172,103): Property 'file' does not exist on type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/updateInfoBuilder.ts (233,9): Argument of type '{ file: string; fileContent: Buffer; arch: null; packager: PlatformPackager; target: null; publishConfig: any; }' is not assignable to parameter of type 'ArtifactCreated'.
Object literal may only specify known properties, and 'file' does not exist in type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/publish/updateInfoBuilder.ts (270,7): Argument of type '{ file: string; arch: null; packager: PlatformPackager; target: null; publishConfig: any; }' is not assignable to parameter of type 'ArtifactCreated'.
Object literal may only specify known properties, and 'file' does not exist in type 'ArtifactCreated'.
packages/app-builder-lib/src/remoteBuilder/builder-cli.ts (1,44): Cannot find module 'electron-publish' or its corresponding type declarations.
packages/app-builder-lib/src/remoteBuilder/builder-cli.ts (4,49): Cannot find module 'builder-util' or its corresponding type declarations.
packages/app-builder-lib/src/remoteBuilder/builder-cli.ts (56,15): Property 'file' does not exist on type 'ArtifactCreated'.
packages/app-builder-lib/src/remoteBuilder/builder-cli.ts (61,7): Argument of type '{ file: any; target: string | null; arch: any; safeArtifactName: string | null | undefined; isWriteUpdateInfo: boolean; updateInfo: any; }' is not assignable to parameter of type 'ArtifactInfo'.
Object literal may only specify known properties, and 'file' does not exist in type 'ArtifactInfo'.
packages/app-builder-lib/src/remoteBuilder/builder-cli.ts (61,19): Property 'file' does not exist on type 'ArtifactCreated'.
packages/app-builder-lib/src/remoteBuilder/builder-cli.ts (63,19): Property 'arch' does not exist on type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/remoteBuilder/RemoteBuilder.ts (2,65): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/remoteBuilder/RemoteBuilder.ts (4,28): Cannot find module 'electron-publish/out/publisher' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/remoteBuilder/RemoteBuilder.ts (123,7): Type '{ file: string; target: FakeTarget | null; packager: PlatformPackager; isWriteUpdateInfo?: boolean | undefined; updateInfo?: any; }' is not assignable to type 'ArtifactCreated'.
Object literal may only specify known properties, and 'file' does not exist in type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/AppImageTarget.ts (1,39): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/AppImageTarget.ts (95,7): Argument of type '{ file: string; safeArtifactName: string | null; target: this; arch: any; packager: LinuxPackager; isWriteUpdateInfo: true; updateInfo: unknown; }' is not assignable to parameter of type 'ArtifactCreated'.
Object literal may only specify known properties, and 'file' does not exist in type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/AppxTarget.ts (2,75): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/AppxTarget.ts (3,38): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/AppxTarget.ts (61,24): Object is of type 'unknown'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/AppxTarget.ts (65,32): Argument of type 'unknown' is not assignable to parameter of type 'string'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/AppxTarget.ts (124,7): Argument of type '{ file: string; packager: WinPackager; arch: any; safeArtifactName: string | null; target: this; isWriteUpdateInfo: boolean | undefined; }' is not assignable to parameter of type 'ArtifactCreated'.
Object literal may only specify known properties, and 'file' does not exist in type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/archive.ts (2,31): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/archive.ts (3,40): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/ArchiveTarget.ts (1,45): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/ArchiveTarget.ts (78,7): Argument of type '{ updateInfo: any; file: string; safeArtifactName: string | null; target: this; arch: any; packager: PlatformPackager; isWriteUpdateInfo: boolean; }' is not assignable to parameter of type 'ArtifactCreated'.
Object literal may only specify known properties, and 'file' does not exist in type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/differentialUpdateInfoBuilder.ts (1,21): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/differentialUpdateInfoBuilder.ts (2,53): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/differentialUpdateInfoBuilder.ts (75,5): Argument of type '{ file: string; safeArtifactName: string | null; target: Target; arch: null; packager: PlatformPackager; updateInfo: any; }' is not assignable to parameter of type 'ArtifactCreated'.
Object literal may only specify known properties, and 'file' does not exist in type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/FlatpakTarget.ts (2,51): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/FlatpakTarget.ts (44,7): Argument of type '{ file: string; safeArtifactName: string | null; target: this; arch: any; packager: LinuxPackager; isWriteUpdateInfo: false; }' is not assignable to parameter of type 'ArtifactCreated'.
Object literal may only specify known properties, and 'file' does not exist in type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/fpm.ts (2,78): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/fpm.ts (3,32): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/fpm.ts (183,41): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/fpm.ts (184,30): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/fpm.ts (193,22): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/LinuxTargetHelper.ts (1,55): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/LinuxTargetHelper.ts (175,44): Object is possibly 'null' or 'undefined'.
packages/app-builder-lib/src/targets/MsiTarget.ts (2,48): Cannot find module 'builder-util' or its corresponding type declarations.
packages/app-builder-lib/src/targets/MsiTarget.ts (3,22): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
packages/app-builder-lib/src/targets/MsiTarget.ts (5,22): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
packages/app-builder-lib/src/targets/MsiTarget.ts (96,7): Argument of type '{ file: string; packager: WinPackager; arch: any; safeArtifactName: string | null; target: this; isWriteUpdateInfo: false; }' is not assignable to parameter of type 'ArtifactCreated'.
Object literal may only specify known properties, and 'file' does not exist in type 'ArtifactCreated'.
packages/app-builder-lib/src/targets/MsiTarget.ts (189,27): Object is of type 'unknown'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/nsis/nsisLang.ts (1,25): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/nsis/nsisLang.ts (28,86): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/nsis/NsisTarget.ts (3,151): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/nsis/NsisTarget.ts (4,103): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/nsis/NsisTarget.ts (5,42): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/nsis/NsisTarget.ts (82,56): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/nsis/NsisTarget.ts (334,7): Argument of type '{ file: string; updateInfo: any; target: this; packager: WinPackager; arch: any; safeArtifactName: string | null; isWriteUpdateInfo: boolean; }' is not assignable to parameter of type 'ArtifactCreated'.
Object literal may only specify known properties, and 'file' does not exist in type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/nsis/NsisTarget.ts (420,69): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/nsis/NsisTarget.ts (421,30): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/nsis/NsisTarget.ts (720,57): Parameter 'file' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/nsis/NsisTarget.ts (720,63): Parameter 'stat' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/nsis/nsisUtil.ts (1,27): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/nsis/nsisUtil.ts (2,33): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/nsis/nsisUtil.ts (4,26): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/pkg.ts (1,40): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/pkg.ts (2,28): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/pkg.ts (69,31): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/pkg.ts (180,58): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/snap.ts (1,156): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/snap.ts (2,25): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/snap.ts (231,7): Argument of type '{ file: string; safeArtifactName: string | null; target: this; arch: any; packager: LinuxPackager; publishConfig: { provider: string; } | null; }' is not assignable to parameter of type 'ArtifactCreated'.
Object literal may only specify known properties, and 'file' does not exist in type 'ArtifactCreated'.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/targetFactory.ts (1,67): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/targetFactory.ts (18,111): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/targets/targetUtil.ts (3,29): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/appBuilder.ts (1,35): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/appBuilder.ts (5,39): Parameter 'rawResult' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/appBuilder.ts (21,5): Parameter 'childProcess' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/appFileCopier.ts (2,39): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/appFileCopier.ts (3,101): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/appFileCopier.ts (50,37): Parameter 'file' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/appFileCopier.ts (245,43): Parameter 'file' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/appFileCopier.ts (246,15): Parameter 'file' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/appFileCopier.ts (246,21): Parameter 'fileStat' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/AppFileWalker.ts (1,38): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/AppFileWalker.ts (55,38): Parameter 'file' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/AppFileWalker.ts (55,44): Parameter 'fileStat' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/AppFileWalker.ts (64,11): Parameter 'file' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/AppFileWalker.ts (64,17): Parameter 'fileStat' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/cacheManager.ts (2,27): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/cacheManager.ts (3,26): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/cacheManager.ts (4,38): Cannot find module 'builder-util/out/promise' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/config.ts (1,92): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/config.ts (2,28): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/filter.ts (1,24): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/filter.ts (52,11): Parameter 'file' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/filter.ts (52,17): Parameter 'stat' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/flags.ts (1,27): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/macosVersion.ts (4,21): Cannot find module 'builder-util/out/log' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/macroExpander.ts (1,43): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/NodeModuleCopyHelper.ts (2,29): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/packageMetadata.ts (1,65): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/repositoryInfo.ts (1,38): Cannot find module 'builder-util/out/promise' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/timer.ts (1,23): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/util/yarn.ts (1,37): Cannot find module 'builder-util' or its corresponding type declarations.
packages/app-builder-lib/src/vm/MonoVm.ts (2,48): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/vm/ParallelsVm.ts (1,66): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/vm/ParallelsVm.ts (17,10): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/vm/ParallelsVm.ts (18,13): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/vm/ParallelsVm.ts (64,164): Parameter 'error' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/vm/ParallelsVm.ts (71,104): Parameter 'error' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/vm/vm.ts (1,88): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/vm/WineVm.ts (2,35): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/wine.ts (2,41): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/winPackager.ts (2,87): Cannot find module 'builder-util' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/winPackager.ts (3,25): Cannot find module 'builder-util-runtime' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/winPackager.ts (4,60): Cannot find module 'builder-util/out/fs' or its corresponding type declarations.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/winPackager.ts (299,30): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/winPackager.ts (300,60): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/winPackager.ts (302,19): Parameter 'it' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/winPackager.ts (359,12): Parameter 'file' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/winPackager.ts (363,42): Parameter 'file' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/winPackager.ts (397,28): Parameter 'file' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/packages/app-builder-lib/src/winPackager.ts (397,34): Parameter 'stat' implicitly has an 'any' type.
/Users/davejeffery/code/forks/electron-builder/node_modules/.pnpm/typescript-json-schema@0.51.0/node_modules/typescript-json-schema/dist/typescript-json-schema.js:1292
throw new Error("No output definition. Probably caused by errors prior to this?");
^

Error: No output definition. Probably caused by errors prior to this?
at Object. (/Users/davejeffery/code/forks/electron-builder/node_modules/.pnpm/typescript-json-schema@0.51.0/node_modules/typescript-json-schema/dist/typescript-json-schema.js:1292:23)
at step (/Users/davejeffery/code/forks/electron-builder/node_modules/.pnpm/typescript-json-schema@0.51.0/node_modules/typescript-json-schema/dist/typescript-json-schema.js:44:23)
at Object.next (/Users/davejeffery/code/forks/electron-builder/node_modules/.pnpm/typescript-json-schema@0.51.0/node_modules/typescript-json-schema/dist/typescript-json-schema.js:25:53)
at /Users/davejeffery/code/forks/electron-builder/node_modules/.pnpm/typescript-json-schema@0.51.0/node_modules/typescript-json-schema/dist/typescript-json-schema.js:19:71
at new Promise ()
at __awaiter (/Users/davejeffery/code/forks/electron-builder/node_modules/.pnpm/typescript-json-schema@0.51.0/node_modules/typescript-json-schema/dist/typescript-json-schema.js:15:12)
at Object.exec (/Users/davejeffery/code/forks/electron-builder/node_modules/.pnpm/typescript-json-schema@0.51.0/node_modules/typescript-json-schema/dist/typescript-json-schema.js:1270:12)
at Object.run (/Users/davejeffery/code/forks/electron-builder/node_modules/.pnpm/typescript-json-schema@0.51.0/node_modules/typescript-json-schema/dist/typescript-json-schema-cli.js:55:30)
at Object. (/Users/davejeffery/code/forks/electron-builder/node_modules/.pnpm/typescript-json-schema@0.51.0/node_modules/typescript-json-schema/bin/typescript-json-schema:3:5)
at Module._compile (node:internal/modules/cjs/loader:1105:14)
ERROR Command failed with exit code 1.

</details>

mmaietta · 2022-08-25T15:28:44Z

Hmmm, are you using a different version of typescript (installed globally)? I just ran a checkout of your PR via gh pr checkout 7075 and ran pnpm install && pnpm generate-all locally and successfully. My node version is 14.19.1

davej · 2022-08-25T23:40:13Z

@mmaietta downgraded to node 14 (from node 16) and everything worked ok. See the latest commit based on your comments.

github-actions bot added app-builder-lib builder-util labels Aug 19, 2022

sandeep1995 approved these changes Aug 20, 2022

View reviewed changes

more lint fixes

e7b3301

github-actions bot added the windows label Aug 22, 2022

davej added 2 commits August 24, 2022 00:35

fix: allow user to define explicit buildNumber in config (electron-…

0da0e9f

…userland#6945) explicit `buildNumber` will take precedence over any envs

typo: buildEnvs -> buildNumberEnvs

6c28c0b

mmaietta reviewed Aug 25, 2022

View reviewed changes

update docs and changeset

2ea46e4

mmaietta merged commit 8166267 into electron-userland:master Aug 28, 2022

github-actions bot mentioned this pull request Aug 28, 2022

chore(deploy): Release #7081

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use `buildVersion` not `buildNumber` for fpm `--iteration` flag #7075

fix: use `buildVersion` not `buildNumber` for fpm `--iteration` flag #7075

davej commented Aug 19, 2022

changeset-bot bot commented Aug 19, 2022 •

edited

netlify bot commented Aug 19, 2022 •

edited

sandeep1995 commented Aug 20, 2022

davej commented Aug 22, 2022

mmaietta commented Aug 23, 2022

davej commented Aug 23, 2022 •

edited

mmaietta commented Aug 23, 2022

davej commented Aug 23, 2022

mmaietta commented Aug 23, 2022 •

edited

davej commented Aug 23, 2022

mmaietta commented Aug 25, 2022

mmaietta Aug 25, 2022 •

edited

mmaietta Aug 25, 2022 •

edited

mmaietta Aug 25, 2022

davej Aug 25, 2022

davej commented Aug 25, 2022 •

edited

mmaietta commented Aug 25, 2022 •

edited

davej commented Aug 25, 2022

fix: use buildVersion not buildNumber for fpm --iteration flag #7075

fix: use buildVersion not buildNumber for fpm --iteration flag #7075

Conversation

davej commented Aug 19, 2022

changeset-bot bot commented Aug 19, 2022 • edited

🦋 Changeset detected

netlify bot commented Aug 19, 2022 • edited

✅ Deploy Preview for car-park-attendant-cleat-11576 ready!

sandeep1995 commented Aug 20, 2022

davej commented Aug 22, 2022

mmaietta commented Aug 23, 2022

davej commented Aug 23, 2022 • edited

mmaietta commented Aug 23, 2022

davej commented Aug 23, 2022

mmaietta commented Aug 23, 2022 • edited

davej commented Aug 23, 2022

mmaietta commented Aug 25, 2022

mmaietta Aug 25, 2022 • edited

Choose a reason for hiding this comment

mmaietta Aug 25, 2022 • edited

Choose a reason for hiding this comment

mmaietta Aug 25, 2022

Choose a reason for hiding this comment

davej Aug 25, 2022

Choose a reason for hiding this comment

davej commented Aug 25, 2022 • edited

mmaietta commented Aug 25, 2022 • edited

davej commented Aug 25, 2022

fix: use `buildVersion` not `buildNumber` for fpm `--iteration` flag #7075

fix: use `buildVersion` not `buildNumber` for fpm `--iteration` flag #7075

changeset-bot bot commented Aug 19, 2022 •

edited

netlify bot commented Aug 19, 2022 •

edited

davej commented Aug 23, 2022 •

edited

mmaietta commented Aug 23, 2022 •

edited

mmaietta Aug 25, 2022 •

edited

mmaietta Aug 25, 2022 •

edited

davej commented Aug 25, 2022 •

edited

mmaietta commented Aug 25, 2022 •

edited