-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(electron-updater): fix backward compatibility for GitHub provider without channels #6998
fix(electron-updater): fix backward compatibility for GitHub provider without channels #6998
Conversation
… without channels Adding support for channels on GitHub was breaking change for those using only pre-release status without channel tags.
🦋 Changeset detectedLatest commit: 2666c98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
maybe fixes #6700 |
This looks great. I'd like to set up a test repo for this so that we can have two different tests for prerelease w/ channels and without. I thought we already had covered these use cases here: https://github.com/electron-userland/electron-builder/blob/master/test/src/updater/nsisUpdaterTest.ts#L279-L305 What's your publish config? |
Thanks for your quick response!
Our flow is using pre-release state on GitHub for opt-in "Early access program" and publishing from Early access to public just by removing pre-release state. |
@mmaietta please let me know how could I help to test it properly / prepare test repo. |
Thanks for adding the expected flows:
Was this previously working this way? Trying to discern if this was a regression or if this changes base functionality of what the definition of I don't see any unit tests with in the Updater Tests that are configured with |
Yes, I believe it is a regression, the expected results were met in v4.6.5 but no more in v5.0.5. |
That's a regression alright 😅
Can you please add to your PR and use |
Merging. I'll add the tests separate :) |
Adding support for channels on GitHub was breaking change for those using only pre-release status without channel tags.
Issues with the current solution (without this PR):
Example 1:
allowPrerelease=true
Expected result is to offer latest 4.0.0 version, but in current state it offers 2.0.0-beta.
Example 2:
allowPrerelease=true
Expected result is to offer pre-released 3.0.0 version, but in current state it offers no update at all.