Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docker): GH Actions for Docker dev/CI and deployments #6537

Merged
merged 3 commits into from
Jan 10, 2022
Merged

chore(docker): GH Actions for Docker dev/CI and deployments #6537

merged 3 commits into from
Jan 10, 2022

Conversation

mmaietta
Copy link
Collaborator

  • detect changed files if going to rebuild docker images during CI
  • tests now run on a locally compiled version of the docker images (should reuse cached versions if no changes detected in dockerfiles)
  • setup docker args to be able to build multiple node versions (currently only 14, in the future -> 16)
  • add git release tags via changesets action
  • optimizing workflows by extracating common actions with better pnpm caching
  • adding automatic docker deployment workflow

Mike Maietta added 2 commits January 9, 2022 16:01
Updating docker file workflow
ed432cf 
- tests now run on a locally compiled version of the docker images (should reuse cached versions if no changes detected in dockerfiles)
- setup script to be able to build both node 14 and 16 images
- add git release tags via changesets action
- optimizing workflows by extracting common actions with better pnpm caching
- detect changed files if going to rebuild docker images during CI
- adding automatic docker deployment
Empty commit
656abf2
@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2022 •
edited

⚠️ No Changeset found

Latest commit: 75b5da9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jan 10, 2022 •
edited

✔️ Deploy Preview for car-park-attendant-cleat-11576 ready!

🔨 Explore the source changes: 75b5da9

🔍 Inspect the deploy log: https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/61dc5f151b8bd30007fdd7b7

😎 Browse the preview: https://deploy-preview-6537--car-park-attendant-cleat-11576.netlify.app

@mmaietta mmaietta merged commit d835aba into electron-userland:master Jan 10, 2022
@mmaietta mmaietta deleted the docker-image-github-action branch January 10, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app-builder-lib electron-updater
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mmaietta