fix: optimize macCodeSign #6522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reason: In M1 macOS laptop, If you skip code signing, it will cause your bundled macOS app not work as behaviour.
e.g. The macOS localization description will not visible in request permission action.
The macOS request permission grant notify will trigger multiple times
I suggest that we can have indicator description to guide our developer to remember this case
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the M1 macOS laptop, If you skip code signing, it will cause your bundled macOS app not to work as behavior.
I suggest that we can have an indicator description to guide our developer to know this case.