Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify protocol as https to complete proxy support fix #6516

Merged
merged 3 commits into from
Dec 28, 2021

Conversation

robertpatrick
Copy link
Contributor

Explicitly set the protocol to https on the request objects to allow publishing to work from behind a proxy server when the https_proxy environment variable is set.

Closes #6286

Explicitly set the protocol to https on the request objects to allow publishing to work from behind a proxy server when the https_proxy environment variable is set.

Closes electron-userland#6286
@changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2021

🦋 Changeset detected

Latest commit: 2a49b2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
electron-publish Patch
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@robertpatrick
Copy link
Contributor Author

@mmaietta with this change and the previously merged change from PR #6410, I can confirm that electron-publisher is able to successfully publish releases to GitHub. Let me know what you think.

@mmaietta mmaietta merged commit 344bb23 into electron-userland:master Dec 28, 2021
@github-actions github-actions bot mentioned this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

electron-publish fails behind proxy server
2 participants