Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support Windows 11 in VMs #6185

Merged
merged 2 commits into from Aug 27, 2021
Merged

fix: Support Windows 11 in VMs #6185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66167ec
fix: Support Windows 11 in VMs
mmaietta Aug 25, 2021
1380972
Create brown-ads-sparkle.md
mmaietta Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/brown-ads-sparkle.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
"app-builder-lib": patch
---

fix: Support Windows 11 in VMs
1 change: 0 additions & 1 deletion packages/app-builder-lib/src/version.ts
View file
Open in desktop
@@ -1,2 +1 @@

export const PACKAGE_VERSION = "22.13.0"
2 changes: 1 addition & 1 deletion packages/app-builder-lib/src/vm/ParallelsVm.ts
View file
Open in desktop
Expand Up @@ -118,6 +118,6 @@ export function macPathToParallelsWindows(file: string) {
export interface ParallelsVm {
id: string
name: string
os: "win-10" | "ubuntu" | "elementary"
os: "win-10" | "win-11" | "ubuntu" | "elementary"
state: "running" | "suspended" | "stopped"
}
2 changes: 1 addition & 1 deletion packages/app-builder-lib/src/vm/vm.ts
View file
Open in desktop
Expand Up @@ -22,7 +22,7 @@ export class VmManager {

export async function getWindowsVm(debugLogger: DebugLogger): Promise<VmManager> {
const parallelsVmModule = await import("./ParallelsVm")
const vmList = (await parallelsVmModule.parseVmList(debugLogger)).filter(it => it.os === "win-10")
const vmList = (await parallelsVmModule.parseVmList(debugLogger)).filter(it => ["win-10", "win-11"].includes(it.os))
if (vmList.length === 0) {
throw new InvalidConfigurationError("Cannot find suitable Parallels Desktop virtual machine (Windows 10 is required)")
}
Expand Down