Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(electron-updater): null object error when MacUpdater logs server port before it is listening #6149

Merged
merged 2 commits into from Aug 14, 2021
Merged

fix(electron-updater): null object error when MacUpdater logs server port before it is listening #6149

merged 2 commits into from Aug 14, 2021

Commits on Aug 12, 2021

  1. Fix null error in proxy server logging 

    Node's HTTP server `address()` method returns `null` until the server is
listening for connections. This commit fixes a bug where `MacUpdater`
attempts to log the server port before it is listening. The existing log
event is still recorded, without the server address. When the server is
listening, a new event is recorded that includes the server address.
    @tessro
    tessro committed Aug 12, 2021
    Copy the full SHA
    945dc87 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2021

  1. Create stale-carrots-listen.md

    @mmaietta
    mmaietta committed Aug 14, 2021
    Copy the full SHA
    5c7a24c View commit details
    Browse the repository at this point in the history