Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log the raw version string when AppUpdater fails to parse semver of latest version #4947

Merged
merged 1 commit into from
May 14, 2020
Merged

Log the raw version string when AppUpdater fails to parse semver of latest version #4947

merged 1 commit into from
May 14, 2020

Commits on May 9, 2020

  1. Log the raw version string 

    When the app updater fails because the version string can't be parsed, we are putting `latestVersion` into the logs, which we know is `null`. That's not too helpful, but putting the raw string from `updateInfo.version` is helpful because you might be able to see what's gone wrong with parsing it.
    @mattjgalloway
    mattjgalloway committed May 9, 2020
    Configuration menu
    Copy the full SHA
    f2cd38e View commit details
    Browse the repository at this point in the history