Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Problem building multiple mac targets:TypeError: pattern.startsWith is not a function #5739

Merged
merged 1 commit into from
May 9, 2021

Conversation

gaodeng
Copy link
Contributor

@gaodeng gaodeng commented Mar 26, 2021

more info #3012

@mmaietta
Copy link
Collaborator

This LGTM I think, but I'm wondering if we should cover this with some basic unit tests in fileTest.ts to validate the file pattern merges. I was under the impression that value was an array.

Do you have a sample config for this?
I was trying to come up with some unit tests over the weekend, then my hackintosh crashed...so I'm working on fixing that

@mmaietta mmaietta self-assigned this Apr 5, 2021
@gaodeng
Copy link
Contributor Author

gaodeng commented Apr 25, 2021

Hi @mmaietta , sorry for not replying in time, I've been too busy lately

Actually fileTest.ts is fine. The root of the problem is DebugLogger.ts, which changes the input parameters.

I'm afraid I can't simply give a configuration file to reproduce the problem. This is because the problem is caused by compiling mac and mas in parallel, so the problem is related to the performance of your machine, and the same configuration that reproduces the problem on my machine may not reproduce it on your machine.

Fortunately, we already know what the problem is, and it's easy to fix

If you still want to reproduce the problem, you can try @mifi 's mifi/lossless-cut#709, which is an open source project, and see if you can reproduce it on your machine

@mmaietta
Copy link
Collaborator

mmaietta commented May 3, 2021

👍 Can you please rebase of latest master? Then we should be good to go

@gaodeng
Copy link
Contributor Author

gaodeng commented May 3, 2021

👍 Can you please rebase of latest master? Then we should be good to go

done

@mmaietta mmaietta merged commit a89edcb into electron-userland:master May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem building multiple mac targets: TypeError: pattern.startsWith is not a function
2 participants