Problem building multiple mac targets: TypeError: pattern.startsWith is not a function #3012

paulingalls · 2018-06-14T00:33:30Z

Electron Builder:

2.15.3:

Electron 2.0.2

Target:

dmg,mas:

I'm running into a problem when I try to build for both dmg,zip and mas.

Basically
"target": ["dmg", "zip"] // works
"target": ["mas"] // works
"target": ["mas", "dmg", "zip"] // shows the error below

Let me know if you need more info...

  TypeError: pattern.startsWith is not a function
    at FileMatcher.normalizePattern (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/fileMatcher.ts:42:17)
    at FileMatcher.patterns.map.it (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/fileMatcher.ts:37:54)
    at Array.map (<anonymous>)
    at new FileMatcher (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/fileMatcher.ts:37:39)
    at /Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/util/AppFileCopierHelper.ts:123:21
    at Generator.next (<anonymous>)
From previous event:
    at _bluebirdLst.default.mapSeries (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/util/AppFileCopierHelper.ts:120:16)
From previous event:
    at /Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/util/AppFileCopierHelper.ts:120:32
    at Generator.next (<anonymous>)
From previous event:
    at copyNodeModules (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/out/util/AppFileCopierHelper.js:319:18)
    at /Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/platformPackager.ts:261:42
    at Generator.next (<anonymous>)
From previous event:
    at then (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/platformPackager.ts:257:14)
From previous event:
    at _computeFileSets (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/platformPackager.ts:258:10)
    at MacPackager.copyAppFiles (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/platformPackager.ts:280:27)
    at /Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/platformPackager.ts:214:10
    at Generator.next (<anonymous>)
    at runCallback (timers.js:794:20)
    at tryOnImmediate (timers.js:752:5)
    at processImmediate [as _immediateCallback] (timers.js:729:5)
From previous event:
    at MacPackager.doPack (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/platformPackager.ts:162:151)
    at /Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/macPackager.ts:107:20
    at Generator.next (<anonymous>)
From previous event:
    at MacPackager.pack (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/macPackager.ts:79:95)
    at /Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/packager.ts:373:24
    at Generator.next (<anonymous>)
    at xfs.stat (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/fs-extra-p/node_modules/fs-extra/lib/mkdirs/mkdirs.js:56:16)
    at /Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/graceful-fs/polyfills.js:287:18
    at FSReqWrap.oncomplete (fs.js:153:5)
From previous event:
    at Packager.doBuild (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/packager.ts:341:39)
    at /Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/packager.ts:317:52
    at Generator.next (<anonymous>)
    at /Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/graceful-fs/graceful-fs.js:99:16
    at /Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/graceful-fs/graceful-fs.js:43:10
    at FSReqWrap.oncomplete (fs.js:135:15)
From previous event:
    at Packager._build (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/packager.ts:294:133)
    at /Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/packager.ts:290:23
    at Generator.next (<anonymous>)
    at runCallback (timers.js:794:20)
    at tryOnImmediate (timers.js:752:5)
    at processImmediate [as _immediateCallback] (timers.js:729:5)
From previous event:
    at Packager.build (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/packager.ts:248:14)
    at /Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/src/index.ts:51:40
    at Generator.next (<anonymous>)
From previous event:
    at build (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder-lib/out/index.js:220:17)
    at build (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder/src/builder.ts:234:10)
    at then (/Users/paulingalls/src/fanzo/desktop/ripl-electron/node_modules/electron-builder/src/cli/cli.ts:46:19)
    at <anonymous>

The text was updated successfully, but these errors were encountered:

popod · 2018-06-18T15:05:44Z

Can you provide the build section of your package.json please. This works for me with electron-builder 2.15.1.

paulingalls · 2018-06-19T17:53:47Z

Here is a cauterized version. This version works, as target is set to just dmg & zip. It breaks if I add mas..

Perhaps it is new behavior with 2.15.3...

"build": {
    "appId": "com.appId",
    "productName": "Name",
    "copyright": "Copyright ©2018 ",
    "files": [
      "app/**/*",
      "node_modules/**/*",
      "package.json"
    ],
    "directories": {
      "buildResources": "resources"
    },
    "mac": {
      "category": "public.app-category.business",
      "type": "distribution",
      "target": ["dmg", "zip"]
    },
    "mas": {
      "provisioningProfile": "resources/prod.provisionprofile",
      "entitlements": "resources/entitlements.mas.plist",
      "entitlementsInherit": "resources/entitlements.mas.inherit.plist",
      "type": "distribution"
    },
    "win": {
      "publisherName": "Ripl",
      "target": [
        {
          "target": "nsis-web",
          "arch": [
            "x64",
            "ia32"
          ]
        },
        {
          "target": "appx",
          "arch": [
            "x64",
            "ia32"
          ]
        }
      ]
    },
    "publish": {
      "provider": "s3",
      "bucket": "bucket",
      "region": "us-east-1",
      "path": "path"
    }
  },

stale · 2019-07-02T04:51:25Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Aarbel · 2019-09-17T21:04:49Z

Any news about this problem & solutions to fix it ? I'm on electron-builder v20.44.4

MartinBarker · 2021-03-21T06:36:06Z

same issue

mmaietta · 2021-03-21T17:30:57Z

@MartinBarker, with latest v22.10.5?

mifi · 2021-03-25T14:14:28Z

Downgrade to v22.10.4 worked for me

Edit: in 22.10.4 it still gives the error, but only if run with DEBUG=electron-builder:

(node:35721) PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 1)
  ⨯ pattern.startsWith is not a function  stackTrace=
                                            TypeError: pattern.startsWith is not a function
                                                at FileMatcher.normalizePattern (node_modules/app-builder-lib/src/fileMatcher.ts:58:17)
                                                at node_modules/app-builder-lib/src/fileMatcher.ts:53:54
                                                at Array.map (<anonymous>)
                                                at new FileMatcher (node_modules/app-builder-lib/src/fileMatcher.ts:53:39)
                                                at computeNodeModuleFileSets (node_modules/app-builder-lib/src/util/appFileCopier.ts:197:21)
                                                at node_modules/app-builder-lib/src/platformPackager.ts:306:36
                                                at async Promise.all (index 0)
                                                at AsyncTaskManager.awaitTasks (node_modules/builder-util/src/asyncTaskManager.ts:65:25)
                                                at MacPackager.doPack (node_modules/app-builder-lib/src/platformPackager.ts:219:5)

I get the error when running npx electron-builder --mac. This results in a broken dist/mas build containing only Electron.app, LICENSE and LICENSES.chromium.html, but dist/mac seems to be successfully built.

When instead running npx electron-builder --mac -m dmg it successfully builds without any error.

mifi · 2021-03-26T03:55:55Z

I added a console.log(from, to, patterns) before this line:

electron-builder/packages/app-builder-lib/src/fileMatcher.ts

Line 53 in c0ae89c

this.patterns = asArray(patterns).map(it => this.normalizePattern(it))

It resulted in many lines like this:

.../lossless-cut .../lossless-cut/dist/mac/Electron.app/Contents/Resources/app/node_modules [
  '**/*',
  'build/**/*',
  'build/**/*',
  '!node_modules/ffmpeg-ffprobe-static/ffmpeg',
  '!node_modules/ffmpeg-ffprobe-static/ffprobe'
]

Then right before pattern.startsWith is not a function came this line:

.../lossless-cut/node_modules/agent-base .../lossless-cut/dist/mas/Electron.app/Contents/Resources/app/node_modules/agent-base/node_modules [
  '**/*',
  'build/**/*',
  'build/**/*',
  '!node_modules/ffmpeg-ffprobe-static/ffmpeg',
  '!node_modules/ffmpeg-ffprobe-static/ffprobe',
  [
    '**/*',
    'build/**/*',
    'build/**/*',
    '!node_modules/ffmpeg-ffprobe-static/ffmpeg',
    '!node_modules/ffmpeg-ffprobe-static/ffprobe'
  ]
]

This leads me to believe there is a bug somewhere lower in the call stack where instead of combining two arrays, some code is instead adding the second array as an item in the base array. But only when multiple targets are running...

mifi · 2021-03-26T03:58:47Z

Seems like this is an old bug. Happened it 2019 also: #4204 (comment)

Maybe it was just hidden all along and just now started to crash the build in the latest version

gaodeng · 2021-03-26T05:30:39Z

I've run into this problem before. I can't quite remember the root cause of the problem right now. But I'll submit a PR later if needed

electron-userland/electron-builder#3012

…th is not a function electron-userland#3012

buu700 · 2021-05-09T14:36:50Z

This is the error I'm getting on macOS (Big Sur 11.3.1, arm64) with Node 14.16.1:

TypeError: pattern.startsWith is not a function
    at FileMatcher.normalizePattern (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/fileMatcher.ts:59:17)
    at /Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/fileMatcher.ts:53:54
    at Array.map (<anonymous>)
    at new FileMatcher (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/fileMatcher.ts:53:39)
    at computeNodeModuleFileSets (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/util/appFileCopier.ts:197:21)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at /Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/platformPackager.ts:306:36
    at async Promise.all (index 0)
    at AsyncTaskManager.awaitTasks (/Users/buu700/cyph/prod/app/cordova-build/node_modules/builder-util/src/asyncTaskManager.ts:65:25)
    at MacPackager.doPack (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/platformPackager.ts:219:5)
    at MacPackager.doPack (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/macPackager.ts:103:9)
    at MacPackager.pack (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/macPackager.ts:158:9)
    at Packager.doBuild (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/packager.ts:434:9)
    at executeFinally (/Users/buu700/cyph/prod/app/cordova-build/node_modules/builder-util/src/promise.ts:12:14)
    at Packager._build (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/packager.ts:369:31)
    at Packager.build (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/packager.ts:333:12)
    at executeFinally (/Users/buu700/cyph/prod/app/cordova-build/node_modules/builder-util/src/promise.ts:12:14)

It looks like the immediate issue is that an empty array is being passed in to normalizePattern rather than a string.

Edit: Applying #5739 as a patch with patch-package worked for me. Thanks @gaodeng!

…With is not a function (#5739) Fixes #3012

mmaietta · 2021-05-09T17:08:42Z

Thanks for verifying that @buu700.
I've approved and merged the PR, it'll make our next release.

gurpreetsingh41333 · 2021-05-20T21:48:38Z

This is the error I'm getting on macOS (Big Sur 11.3.1, arm64) with Node 14.16.1:

TypeError: pattern.startsWith is not a function
    at FileMatcher.normalizePattern (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/fileMatcher.ts:59:17)
    at /Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/fileMatcher.ts:53:54
    at Array.map (<anonymous>)
    at new FileMatcher (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/fileMatcher.ts:53:39)
    at computeNodeModuleFileSets (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/util/appFileCopier.ts:197:21)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at /Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/platformPackager.ts:306:36
    at async Promise.all (index 0)
    at AsyncTaskManager.awaitTasks (/Users/buu700/cyph/prod/app/cordova-build/node_modules/builder-util/src/asyncTaskManager.ts:65:25)
    at MacPackager.doPack (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/platformPackager.ts:219:5)
    at MacPackager.doPack (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/macPackager.ts:103:9)
    at MacPackager.pack (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/macPackager.ts:158:9)
    at Packager.doBuild (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/packager.ts:434:9)
    at executeFinally (/Users/buu700/cyph/prod/app/cordova-build/node_modules/builder-util/src/promise.ts:12:14)
    at Packager._build (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/packager.ts:369:31)
    at Packager.build (/Users/buu700/cyph/prod/app/cordova-build/node_modules/app-builder-lib/src/packager.ts:333:12)
    at executeFinally (/Users/buu700/cyph/prod/app/cordova-build/node_modules/builder-util/src/promise.ts:12:14)

It looks like the immediate issue is that an empty array is being passed in to normalizePattern rather than a string.

Edit: Applying #5739 as a patch with patch-package worked for me. Thanks @gaodeng!

can you please add the steps on how you resolved this issue?

buu700 · 2021-05-21T04:19:26Z

Sure, just use patch-package with the attached patch.

Edit: Or just use the current stable version of builder-util (22.11.5), which already has the fix included.

builder-util+22.10.5.patch

stale bot added the backlog label Jul 2, 2019

stale bot closed this as completed Jul 9, 2019

mmaietta reopened this Mar 25, 2021

stale bot removed the backlog label Mar 25, 2021

mifi added a commit to mifi/lossless-cut that referenced this issue Mar 26, 2021

revert buggy 22.10.5 upgrade

3ba00a0

electron-userland/electron-builder#3012

mifi mentioned this issue Mar 26, 2021

Fix building so that mas-dev works mifi/lossless-cut#709

Closed

gaodeng added a commit to gaodeng/electron-builder that referenced this issue Mar 26, 2021

Fix Problem building multiple mac targets:TypeError: pattern.startsWi…

9d86d44

…th is not a function electron-userland#3012

gaodeng mentioned this issue Mar 26, 2021

Fix Problem building multiple mac targets:TypeError: pattern.startsWith is not a function #5739

Merged

gaodeng added a commit to gaodeng/electron-builder that referenced this issue May 3, 2021

Fix Problem building multiple mac targets:TypeError: pattern.startsWi…

11e77f4

…th is not a function electron-userland#3012

mmaietta linked a pull request May 9, 2021 that will close this issue

Fix Problem building multiple mac targets:TypeError: pattern.startsWith is not a function #5739

Merged

mmaietta closed this as completed in #5739 May 9, 2021

mmaietta pushed a commit that referenced this issue May 9, 2021

fix: Problem building multiple mac targets: TypeError: pattern.starts…

a89edcb

…With is not a function (#5739) Fixes #3012

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Problem building multiple mac targets: TypeError: pattern.startsWith is not a function #3012

Problem building multiple mac targets: TypeError: pattern.startsWith is not a function #3012

paulingalls commented Jun 14, 2018

popod commented Jun 18, 2018

paulingalls commented Jun 19, 2018 •

edited

stale bot commented Jul 2, 2019

Aarbel commented Sep 17, 2019 •

edited

MartinBarker commented Mar 21, 2021

mmaietta commented Mar 21, 2021

mifi commented Mar 25, 2021 •

edited

mifi commented Mar 26, 2021

mifi commented Mar 26, 2021

gaodeng commented Mar 26, 2021

buu700 commented May 9, 2021 •

edited

mmaietta commented May 9, 2021

gurpreetsingh41333 commented May 20, 2021

buu700 commented May 21, 2021 •

edited

Problem building multiple mac targets: TypeError: pattern.startsWith is not a function #3012

Problem building multiple mac targets: TypeError: pattern.startsWith is not a function #3012

Comments

paulingalls commented Jun 14, 2018

popod commented Jun 18, 2018

paulingalls commented Jun 19, 2018 • edited

stale bot commented Jul 2, 2019

Aarbel commented Sep 17, 2019 • edited

MartinBarker commented Mar 21, 2021

mmaietta commented Mar 21, 2021

mifi commented Mar 25, 2021 • edited

mifi commented Mar 26, 2021

mifi commented Mar 26, 2021

gaodeng commented Mar 26, 2021

buu700 commented May 9, 2021 • edited

mmaietta commented May 9, 2021

gurpreetsingh41333 commented May 20, 2021

buu700 commented May 21, 2021 • edited

paulingalls commented Jun 19, 2018 •

edited

Aarbel commented Sep 17, 2019 •

edited

mifi commented Mar 25, 2021 •

edited

buu700 commented May 9, 2021 •

edited

buu700 commented May 21, 2021 •

edited