fix(nsis): should close app when Silent and ONE_CLICK

electron-userland · Jul 26, 2021 · 13f313e · 13f313e
1 parent 58770bb
commit 13f313e
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/packages/app-builder-lib/templates/nsis/uninstaller.nsh b/packages/app-builder-lib/templates/nsis/uninstaller.nsh
@@ -1,7 +1,9 @@
 Function un.onInit
   !insertmacro check64BitAndSetRegView
 
-  ${IfNot} ${Silent}
+  ${If} ${Silent}
+    !insertmacro CHECK_APP_RUNNING
+  ${else}
     !ifdef ONE_CLICK
       MessageBox MB_OKCANCEL "$(areYouSureToUninstall)" IDOK +2
       Quit
@@ -20,9 +22,11 @@ Function un.onInit
 FunctionEnd
 
 Section "un.install"
+  # for assisted installer we check it here to show progress
   !ifndef ONE_CLICK
-    # for assisted installer we check it here to show progress
-    !insertmacro CHECK_APP_RUNNING
+    ${IfNot} ${Silent}
+      !insertmacro CHECK_APP_RUNNING
+    ${endIf}
   !endif
 
   !insertmacro setLinkVars