-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add electron-redux module #603
Add electron-redux module #603
Conversation
…ded. For example the case of having a store specific to the main process vs the renderer process or even could be used to combine the development and production stores and add what is needed based on the ENV.
…ed in at store creation
@dustintownsend Hey. Nothing glaringly obvious I can spot. |
Might be worth adding some examples of, e.g. async actions, local or aliased actions. |
@hardchor do you have any insight into why the test are failing? It is failing at replyActionMain.js at ipcMain.on. It seems that ipcMain is not importing. I assume its due to not being in electron but a test, but I don't know enough about testing to be 100%. |
#573 (comment) have provided a workaround, maybe we can migrate to |
If this is a unit test, you'll probably need to mock |
I'm going to close this for now. I'm not sure this is a good fit for the boilerplate right now. I think it would be better as an optional add on. |
What are the core maintainer's thoughts? I could have another go at this once the jest PR is in. /cc @jhen0409 @amilajack |
I'm not very experienced with redux. @jhen0409 and @chentsulin may have more to say about this |
This uses the proposed changed in PR #602.
I have the need for syncing the state between main and renderer, so this is my first pass. Based on the discussion from Issue #108 I decided to try https://github.com/hardchor/electron-redux/ first. I may do another PR for redux-electron-store and an alternative.
@burkhardr can you look over this and see if I got any of the implementation wrong? I based it on your timesheets repo.