[minor] [chore] : Update to support Lerna structure #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
animesh10
changed the title
didi0613
reviewed
Aug 1, 2017
| data.deps = moduleDeps; | ||
| // Fetch the repo data file if it already exists | ||
| let repoFile = {}; | ||
| let writePath = Path.join(__dirname, `../../data/${moduleName}.json`); |
There was a problem hiding this comment.
Shall we use const here since writePath won't change.
And if try catch is to verify if the path exists, you can use optional-require: https://www.npmjs.com/package/optional-require
server/component-api/fetch-repo.js
Outdated
| //fetch top level package.json for repo | ||
| readPackageContent(org, repoName, "package.json") | ||
| .then(response => { | ||
| let packageContent = contentToString(response.content); |
didi0613
reviewed
Oct 24, 2017
| if (err) { | ||
| console.log(err); | ||
| return; | ||
| } | ||
|
|
||
| exec(`crontab ${filePath}`, (error) => { | ||
| exec(`crontab ${filePath}`, (error, stdout, stderr) => { |
There was a problem hiding this comment.
Saw some unused references here: stdout, stderr.
Please fix all the linter errors :-)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.