Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile release PR #6758

Merged
merged 4 commits into from
May 27, 2024
Merged

Mobile release PR #6758

merged 4 commits into from
May 27, 2024

Conversation

tonypls
Copy link
Collaborator

@tonypls tonypls commented May 16, 2024

Issue

Updated fastlane and had to update JDK locally maybe because of new capacitor version?

@github-actions github-actions bot added mobile app 📱 dependencies Pull requests that update a dependency file labels May 16, 2024
@VIKTORVAV99
Copy link
Member

VIKTORVAV99 commented May 16, 2024 •
edited

I this needed to be merged to actually release them?
I have some changes in the contrib update PR that is potentially breaking and we need to be able to revert quickly.

@tonypls
Copy link
Collaborator Author

tonypls commented May 16, 2024

I this needed to be merged to actually release them? I have some changes in the contrib update PR that is potentially breaking and we need to be able to revert quickly.

I this needed to be merged to actually release them? I have some changes in the contrib update PR that is potentially breaking and we need to be able to revert quickly.

No it's not needed, I put it in for two reasons:

  1. It's an easier way to document the exact state of the repo at a given mobile release
  2. It keeps mobileapp project in sync so not too much changes next time (hopefully just the version number bump)

madsnedergaard
madsnedergaard approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@madsnedergaard madsnedergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (so you can merge when ready)

@tonypls tonypls enabled auto-merge (squash) May 27, 2024 08:39
@tonypls tonypls merged commit 8d200eb into master May 27, 2024
18 checks passed
@tonypls tonypls deleted the tvs/mobile-release-1.136.0 branch May 27, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsnedergaard madsnedergaard madsnedergaard approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file mobile app 📱
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tonypls @VIKTORVAV99 @madsnedergaard