fix(web): axis units overflowing graphcard #6754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIKTORVAV99
reviewed
May 15, 2024
| @@ -20,7 +20,7 @@ import GraphHoverLine from './GraphHoverline'; | |||
| import ValueAxis from './ValueAxis'; | |||
|
|
|||
| const X_AXIS_HEIGHT = 20; | |||
| const Y_AXIS_WIDTH = 20; | |||
| const Y_AXIS_WIDTH = 26; | |||
There was a problem hiding this comment.
Just an idea here, but not sure if it should be in this PR or just a future improvement but it would be nice to calculate the actual width needed instead of having to use a constant.
There was a problem hiding this comment.
Yes that would be nice! In the design review meeting we discussed units which will also affect how much space is needed, so I think it is a future thing.
|
I just changed some things after we discussed it in the meeting. I should have let you know, sorry @VIKTORVAV99 |
|
It should be ready for review again now! |
tonypls
reviewed
May 15, 2024
tonypls
reviewed
May 15, 2024
|
Wow, you very quickly and easily just fixed the disabled message - you're awesome! 💪 |
VIKTORVAV99
reviewed
May 15, 2024
Co-authored-by: Viktor Andersson <30777521+VIKTORVAV99@users.noreply.github.com>
|
Ready for review again ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
These two pictures show 2 issues related to axis units overflowing.
This issue is caused by the
formatCo2function not handling negative values correctly, partly because the value to match set inNetExchangeChartwas not taking into account that the number could be negative, and partly because the method itself didn't account for negative values.The second issue is that the gray overlay was not wide enough to cover the axis units.
Description
This PR fixes these two issues so that the axis show negative values correctly and it widens the gray overlay.
Preview
Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.