Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ch): update CH parser with 2023 and 2024 data #6668

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amv213
Copy link
Contributor

@amv213 amv213 commented Apr 17, 2024

Description

I noticed that the hard-coded solar capacity data used by the CH parser might be a bit out of date. Similarly to what was done in #5529, this PR adds values for 2023 and 2024 and updates the existing values based on the latest data that I found available on the dashboard linked to in the code comments.

P.S. dashboards / data would also be available on the same website for hydro, wind, and biomass capacities. Is this something we would be interested in integrating too?

And if it can be useful, the data that powers the pie-chart showing the current-year capacities is here:

What's nice is that it includes capacities for sources (e.g. nuclear) that don't otherwise have their own dashboard, but we cannot get any historical data beyond the current year

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added parser python Pull requests that update Python code tests zone config Pull request or issue for zone configurations labels Apr 17, 2024
parsers/CH.py Outdated Show resolved Hide resolved
@VIKTORVAV99
Copy link
Member

Sorry about taking a while to review this, we found a bug in the logic related to the capacities that #6703 should temporarily fix.

I will be taking some extra care when reviewing this so we don't reintroduce the error while we are looking for a more permanent fix but that means it can take a bit longer to be reviewed.

Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this returns floats instead of int's it should work without issue with the backend, however there is a merge conflict which needs to be resolved.

Once that is sorted I'll I'd be happy to merge this :)

@amv213 amv213 force-pushed the amv213/update-hardcoded-ch-solar-capacities branch from 59a1925 to 1d27a95 Compare May 13, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser python Pull requests that update Python code tests zone config Pull request or issue for zone configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants