Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIA capacity update for 2024 #6626

Closed
wants to merge 2 commits into from
Closed

Conversation

VIKTORVAV99
Copy link
Member

Issue

We are missing EIA 2024 capacities.

Description

Updates all EIA zones with 2024 capacities.

Double check

  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added the zone config Pull request or issue for zone configurations label Apr 3, 2024
@VIKTORVAV99 VIKTORVAV99 mentioned this pull request Apr 3, 2024
2 tasks
Copy link
Contributor

@KabelWlan KabelWlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments regarding zones that you aggregate generation. I think you should thus aggregate the capacities as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're already making changes to the capacities. I would change the wind capacity as the generation from the AVRN zone is included in the BPAT zone. I would therefore change the wind capacity to 5314.8

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly thought it was already doing that...

Since we are now using a parser for updating these values we want to avoid manual changes as much as possible. However I think fixing the parser itself is out of scope for this PR but I'll open a issue about it so it can be adressed later.

@@ -52,6 +55,9 @@ capacity:
- datetime: '2023-10-01'
source: EIA.gov
value: 452.9
- datetime: '2024-01-01'
source: EIA.gov
value: 763.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use the aggregated number for NWMT, GWA and WWA as you aggregate generation for those zones. Furthermore, the Clearwater Wind 1 wind farm is in the EIA report wrongly accounted to PSEI. The generation is shown in the NWMT zone. The aggregated number would thus be 1528.1

@pierresegonne
Copy link
Member

Looks good, can you confirm that you've reallocated capacity for zones that are aggregated into others?

@VIKTORVAV99
Copy link
Member Author

Looks good, can you confirm that you've reallocated capacity for zones that are aggregated into others?

I have not, that would require parser changes. I have only run the parser itself in this PR.

@pierresegonne
Copy link
Member

I have not, that would require parser changes. I have only run the parser itself in this PR

Can you check that it was the case before as well? If it's the case, then let's go ahead with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
capacity zone config Pull request or issue for zone configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants