-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove arrow from CO parser #6573
base: master
Are you sure you want to change the base?
refactor: remove arrow from CO parser #6573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several small fixes needed but looks to be on the right track!
Thanks for upgrading this parser.
@VIKTORVAV99 I researched the difference between .replace() and astimezone() for changing timezones and indeed it looks like astimezone() is the preferred method. I used replace() in my refactor for both CA_AB and CA_BC - do you want me to go back and update those to astimezone(), or are you ok with those as they are? |
In general I think where we used The absolut best way to ensure there is no missmatch between the two would be to add snapshot tests before modifying them and then making sure the date times don't change (more than the tz info). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments, otherwise it looks great!
Issue #6135
Description
Removes arrow dependency from CO parser.
Note: It seems the 'fecha' datapoint sometimes is missing the full millisecond precision, so there is a check to add a trailing zero if that is the case
Preview
Double check
poetry run test_parser "zone_key"
pnpx prettier@2 --write .
andpoetry run format
in the top level directory to format my changes.