refactor: use event classes in US-SPP parser #6553
Open
+103
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parser
python
VIKTORVAV99
reviewed
Mar 12, 2024
VIKTORVAV99
reviewed
Mar 23, 2024
parsers/US_SPP.py
Outdated
Comment on lines
343
to
351
| def fetch_historical_exchange( | ||
| zone_key1: str, | ||
| zone_key2: str, | ||
| zone_key1: ZoneKey, | ||
| zone_key2: ZoneKey, | ||
| session: Session | None = None, | ||
| target_datetime: datetime | None = None, | ||
| logger: Logger = getLogger(__name__), | ||
| ) -> list: | ||
| ) -> list[dict[str, Any]]: | ||
| filename = target_datetime.strftime("TieFlows_%b%Y.csv") | ||
| file_url = f"{US_PROXY}/file-browser-api/download/historical-tie-flow?{HOST_PARAMETER}&path={filename}" |
There was a problem hiding this comment.
Not really part of your changes but I don't think the target datetime should be None here, type wise. Or it should be checked that it's not none before the filename is generated as .strftime is not available on None.
There was a problem hiding this comment.
Fixed both! Sorry it's been a while!
yujia21
force-pushed
the
6011-event-class-US-SPP
branch
from
d021de5
to
ee6fe70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
6011
Description
Use event classes in US-SPP parser
Preview
Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.