Bugfix france parser price calc #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@steinwinde you also pushed in this PR the commits you PR'd via #2450. Could you remove them from this PR please ? |
jarek
reviewed
May 2, 2020
parsers/FR.py
Outdated
| @@ -171,7 +171,7 @@ def fetch_price(zone_key, session=None, target_datetime=None, | |||
| if value.text == 'ND': | |||
| continue | |||
| period = int(value.attrib['periode']) | |||
| datetime = start_date.replace(hours=+period).datetime | |||
| datetime = start_date.replace(hour=+period).datetime | |||
There was a problem hiding this comment.
Suggested change
| datetime = start_date.replace(hour=+period).datetime | |
| datetime = start_date.shift(hours=+period).datetime |
see #2416 (comment)
robertahunt
approved these changes
May 4, 2020
|
Just want to get this included in the upcoming bump of contrib :) |
con-cat
pushed a commit
to con-cat/electricitymap-contrib
that referenced
this pull request
May 18, 2021
* Added API key information and some smaller corrections to README. * Corrected position of API key information and promoted a section from sub-sub to sub level in the README. * Replaced "hours" by "hour" to make the FR.py work. * Corrected arrow funtion in price calc of FR parser. * Corrected README version to point to master, not my last pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced "hours" by "hour" to make the FR.py work.