Fix some spelling in the README and add some info. #103
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## default #103 +/- ##
========================================
Coverage 99.20% 99.20%
========================================
Files 45 45
Lines 1626 1626
Branches 114 114
========================================
Hits 1613 1613
Misses 6 6
Partials 7 7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Better to put this into
tutorial>features>books.feature
And link to this file from the tests directory by books.desktop file
There was a problem hiding this comment.
Please review blaisep#3 and share your thoughts
docs/tutorial/tests/conftest.py
Outdated
| @@ -0,0 +1,5 @@ | |||
| from steps.library_steps import * | |||
There was a problem hiding this comment.
* syntax is a bad pattern; better to list all imported steps.
|
|
||
| @when(parsers.re("a (?P<search_type>name|title) search is performed for " + | ||
| "(?P<search_term>.+)")) | ||
| def a_SEARCH_TYPE_is_performed_for_SEARCH_TERM(search_type, search_term): |
There was a problem hiding this comment.
context fixture is missing
There was a problem hiding this comment.
def a_SEARCH_TYPE_is_performed_for_SEARCH_TERM(search_type, search_term, context):
| Tutorial for Behave/Cucumber users | ||
| ================================== | ||
|
|
||
| .. _tutorial: https://thebddcoach.com/post/a-quick-introduction-to-pytest-bdd-ng-for-people-who-are-already-familiar-with-cucumber-or-behave/ |
There was a problem hiding this comment.
A better idea is to rewrite the tutorial inside a project and make it updatable by the repository owner. If we have a tutorial as part of the e2e suite - it won't become outdated.
Adjust tutorial to be executed during e2e test launch
for more information, see https://pre-commit.ci
The idea I had here was to describe the intent of each example and perhaps arrange them in order of complexity.
for more information, see https://pre-commit.ci
In this commit, the guide explains how to set up the dagger client and provides a simple exercise to get you started.
for more information, see https://pre-commit.ci
@elchupanebrej , I made some small changes to the README to help with grammar and also to check my workflow.