feat: location info for journey and step #474
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
| @@ -315,3 +321,36 @@ export function parseNetworkConditions(args: string): NetworkConditions { | |||
|
|
|||
| return networkConditions; | |||
| } | |||
|
|
|||
| // default stack trace limit | |||
| const dstackTraceLimit = 10; | |||
There was a problem hiding this comment.
Should we allow setting this value through an environment variable as Jest and others do?
There was a problem hiding this comment.
Hmmm, interesting point. Do you think it provides value? In the past, I had used them when V8 async promise stack trace was not done correctly and even if you do increase the stack trace limit, its only going to show the Jest stack traces which seems not so useful to me. WDYT?
There was a problem hiding this comment.
I've previously used this on Deno and I use a similar option to debug errors on test diffs, although that's not exactly a stack trace, it's similar.
I don't think it's a very important change, it just came to mind because it was helpful for me in the past, although in very very few situations.
Also, even if it shows our stack frames, it could be useful to help users report bugs to us (that is, if we don't cut our stack frames straightaway).
There was a problem hiding this comment.
Sounds good, if its useful let's do it. Let me follow up with a PR.
pushcommand to sync with monitor management #470Locationmetadata to the Journey and Step DSL which can be used for formatting the error location and pinpointing to the exact source on the test files. Location metadata is not used anywhere as it lays the foundation for pushing journeys to the monitor management. Will be used in the subsequent PR's.ts-nodewhich we use to transpile the journey files on the fly and thesource-map-supportlibrary as both were looking in different places for the original source-maps.ts-nodemoved to a forked version of the library. More details here - Improvements and bugfixes compared tosource-map-supportcspotcode/node-source-map-support#24