Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sinatra constraint #14446

Merged
merged 1 commit into from Aug 17, 2022
Merged

remove sinatra constraint #14446

merged 1 commit into from Aug 17, 2022

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Aug 16, 2022

Sinatra 2.2.1 fixes #13777 through sinatra/sinatra#1750:

Fix JRuby regression by using ruby2_keywords for delegation. #1750 by Patrik Ragnarsson

Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsvd jsvd merged commit 24c675c into elastic:main Aug 17, 2022
@jsvd
Copy link
Member Author

jsvd commented Aug 17, 2022

@logstashmachine backport 8.4

@jsvd
Copy link
Member Author

jsvd commented Aug 17, 2022

@logstashmachine backport 7.17

@jsvd jsvd deleted the relax_sinatra_contraint branch August 17, 2022 09:04
github-actions bot pushed a commit that referenced this pull request Aug 17, 2022
(cherry picked from commit 24c675c)
github-actions bot pushed a commit that referenced this pull request Aug 17, 2022
(cherry picked from commit 24c675c)
robbavey pushed a commit to robbavey/logstash that referenced this pull request Aug 22, 2022
(cherry picked from commit 24c675c)

Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
robbavey pushed a commit to robbavey/logstash that referenced this pull request Aug 24, 2022
(cherry picked from commit 24c675c)

Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An unexpected error occurred! {:error=>#<ArgumentError: wrong number of arguments (given 3, expected 1..2)>
3 participants