Backport PR #14185 to 7.16: Deps: lock faraday to 1.x due elasticsearch-transport #14189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #14185 to 7.16 branch, original message:
Release notes
[rn:skip]
What does this PR do?
Dependency restriction, due the elasticsearch dependency.
Elasticsearch client is used in logstash-input-elasticsearch and logstash-filter-elasticsearch.
The client has a transitive dependency on faraday '-> 1' (even in 8.x)
Avoids ruby unit test failures (such as this)
Why is it important/What is the impact to the user?
Users would not end up with latest versions of the ES plugins if we're using latest Faraday 2.x.
This mostly concerns development and users checking out the main branch atm.
How to test this PR locally
Related