bump up babel version #61037

mshustov · 2020-03-24T08:09:14Z

Summary

A prerequisite for TypeScript update #57774
I didn't add onlyRemoveTypeImports which should be done in ^^^

//packages/kbn-babel-preset/common_preset.js
[
  require.resolve('@babel/preset-typescript'),
  { allowNamespaces: true, onlyRemoveTypeImports: true },
],

more details babel/babel#11173, babel/babel#10981, babel/babel#11171

Testing locally might require yarn kbn clean

elasticmachine · 2020-03-24T09:10:10Z

Pinging @elastic/kibana-operations (Team:Operations)

elasticmachine · 2020-03-24T10:23:40Z

Pinging @elastic/kibana-platform (Team:Platform)

Bamieh

kbn-analytics package babel version bump lgtm

afharo

I'm getting errors when bootstrapping it:

 succ [@elastic/datemath] cache up to date
 succ [@kbn/config-schema] cache up to date
 succ [@kbn/utility-types] cache up to date
 succ [@kbn/dev-utils] cache up to date
@kbn/babel-code-parser: $ yarn build --quiet
@kbn/babel-code-parser: $ babel src --out-dir target --quiet
✖ @kbn/babel-code-parser: { Error: [BABEL] /Users/afharo/Developer/kibana/packages/kbn-babel-code-parser/src/can_require.js: Cannot find module 'lodash/clone'\n    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)\n    at Function.Module._load (internal/modules/cjs/loader.js:562:25)\n    at Module.require (internal/modules/cjs/loader.js:692:17)\n    at require (internal/modules/cjs/helpers.js:25:18)\n    at Object.<anonymous> (/Users/afharo/Developer/kibana/node_modules/@babel/plugin-transform-typescript/node_modules/@babel/types/lib/builders/builder.js:8:37)\n    at Module._compile (internal/modules/cjs/loader.js:778:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)\n    at Module.load (internal/modules/cjs/loader.js:653:32)\n    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)\n    at Function.Module._load (internal/modules/cjs/loader.js:585:3) code: 'MODULE_NOT_FOUND' }
@kbn/babel-code-parser: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
✖ @kbn/babel-code-parser: error Command failed with exit code 1.
@kbn/babel-code-parser: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
✖ @kbn/babel-code-parser: error Command failed with exit code 1.

[bootstrap] failed:

Error: Command failed with exit code 1: yarn run kbn:bootstrap
{ Error: [BABEL] /Users/afharo/Developer/kibana/packages/kbn-babel-code-parser/src/can_require.js: Cannot find module 'lodash/clone'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/Users/afharo/Developer/kibana/node_modules/@babel/plugin-transform-typescript/node_modules/@babel/types/lib/builders/builder.js:8:37)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3) code: 'MODULE_NOT_FOUND' }
error Command failed with exit code 1.
error Command failed with exit code 1.
$ yarn build --quiet
$ babel src --out-dir target --quiet
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
    at makeError (/Users/afharo/Developer/kibana/packages/kbn-pm/dist/index.js:33441:11)
    at handlePromise (/Users/afharo/Developer/kibana/packages/kbn-pm/dist/index.js:32377:26)
    at process._tickCallback (internal/process/next_tick.js:68:7)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
➜  kibana git:(bump-babel)

afharo · 2020-03-24T10:32:36Z

packages/kbn-pm/dist/index.js

@@ -47554,7 +47554,7 @@ __webpack_require__.r(__webpack_exports__);
 /* harmony import */ var _scripts__WEBPACK_IMPORTED_MODULE_7__ = __webpack_require__(562);


isn't it interesting the dist/ dir is pushed to GitHub?

Unrelated to this PR. Just adding a heads up to @elastic/kibana-operations 🤔

kbn/pm is used to install dependencies with kbn bootstrap before any node module is installed, so it has to bundle the node_modules it needs in a file that git can put in place, which is why it's committed to the repo.

mshustov · 2020-03-24T10:35:24Z

@afharo Could you run yarn kbn clean and then bootstrap?

lizozom

Code owner changes LGTM

afharo · 2020-03-24T11:59:45Z

@afharo Could you run yarn kbn clean and then bootstrap?

cleaning first did the trick

afharo

Pulse changes LGTM!

spalger · 2020-03-24T17:39:04Z

cleaning first did the trick

yarn, why do you like to make me sad

spalger

LGTM, merged master and updated the transitive @babel/* deps in yarn.lock too so a clean shouldn't be necessary anymore.

kibanamachine · 2020-03-24T23:24:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 9d24a3c

History

💔 Build #35905 failed 4082851
💛 Build #35716 was flaky 4368d4b
💔 Build #35714 failed 1fd2b09

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* bump babel version * build kbm-pm * refresh transitive @babel/* versions to kick yarn into shape * update kbn/pm dist Co-authored-by: spalger <spalger@users.noreply.github.com>

* bump up babel version (#61037) * bump babel version * build kbm-pm * refresh transitive @babel/* versions to kick yarn into shape * update kbn/pm dist Co-authored-by: spalger <spalger@users.noreply.github.com> * stop using deprecated source-map option Co-authored-by: spalger <spalger@users.noreply.github.com>

mshustov added 2 commits March 24, 2020 09:08

bump babel version

1fd2b09

build kbm-pm

4368d4b

mshustov added chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.8.0 labels Mar 24, 2020

mshustov mentioned this pull request Mar 24, 2020

update to TypeScript v3.8-rc #57774

Closed

7 tasks

mshustov marked this pull request as ready for review March 24, 2020 10:08

mshustov requested review from a team as code owners March 24, 2020 10:08

mshustov added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Mar 24, 2020

Bamieh approved these changes Mar 24, 2020

View reviewed changes

afharo requested changes Mar 24, 2020

View reviewed changes

afharo reviewed Mar 24, 2020

View reviewed changes

lizozom approved these changes Mar 24, 2020

View reviewed changes

afharo approved these changes Mar 24, 2020

View reviewed changes

spalger added 2 commits March 24, 2020 10:46

Merge branch 'master' of github.com:elastic/kibana into pr/61037

5cfe255

refresh transitive @babel/* versions to kick yarn into shape

4082851

spalger approved these changes Mar 24, 2020

View reviewed changes

spalger added 2 commits March 24, 2020 14:40

Merge branch 'master' of github.com:elastic/kibana into pr/61037

fd5eebd

update kbn/pm dist

9d24a3c

mshustov merged commit a8f92c5 into elastic:master Mar 25, 2020

mshustov deleted the bump-babel branch March 25, 2020 15:37

mshustov mentioned this pull request Mar 25, 2020

bump up babel version (#61037) #61303

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump up babel version #61037

bump up babel version #61037

mshustov commented Mar 24, 2020 •

edited

elasticmachine commented Mar 24, 2020

elasticmachine commented Mar 24, 2020

Bamieh left a comment

afharo left a comment

afharo Mar 24, 2020 •

edited

spalger Mar 24, 2020

mshustov commented Mar 24, 2020 •

edited

lizozom left a comment

afharo commented Mar 24, 2020

afharo left a comment

spalger commented Mar 24, 2020

spalger left a comment

kibanamachine commented Mar 24, 2020

		@@ -47554,7 +47554,7 @@ __webpack_require__.r(__webpack_exports__);
		/* harmony import */ var _scripts__WEBPACK_IMPORTED_MODULE_7__ = __webpack_require__(562);

bump up babel version #61037

bump up babel version #61037

Conversation

mshustov commented Mar 24, 2020 • edited

Summary

elasticmachine commented Mar 24, 2020

elasticmachine commented Mar 24, 2020

Bamieh left a comment

Choose a reason for hiding this comment

afharo left a comment

Choose a reason for hiding this comment

afharo Mar 24, 2020 • edited

Choose a reason for hiding this comment

spalger Mar 24, 2020

Choose a reason for hiding this comment

mshustov commented Mar 24, 2020 • edited

lizozom left a comment

Choose a reason for hiding this comment

afharo commented Mar 24, 2020

afharo left a comment

Choose a reason for hiding this comment

spalger commented Mar 24, 2020

spalger left a comment

Choose a reason for hiding this comment

kibanamachine commented Mar 24, 2020

💚 Build Succeeded

History

mshustov commented Mar 24, 2020 •

edited

afharo Mar 24, 2020 •

edited

mshustov commented Mar 24, 2020 •

edited