Use HTTP request schemas to create types, use those types in the client #59340

oatkiller · 2020-03-04T17:42:37Z

Summary

Use a type derived from @kbn/config-schema on the client when creating requests.

Backstory

When creating an HTTP route, we use @kbn/config-schema to create 'schema' objects. These schemas are used to validate and coerce the inputs to the HTTP handler (e.g. HTTP query strings, POST bodies.) The client will make HTTP requests to these handlers. If the HTTP requests made by the client fail the validation, an HTTP error will be triggered. In that case an error will likely be shown to the user.

In the HTTP handler code the validated (and coerced) inputs are cast to a type based on the schema. This is called the TypeOf<schema> type. This allows the HTTP handlers to have type safety.

If the schema changes, the HTTP handler will get a new type, and the developer will be informed (by typecheck) that the HTTP handler code must change.

Ideas

This PR is a POC. It defines a pattern for extending the type safety to the client. The idea is this:

Centralize the schemas into a common area, accessible by public and server code
Still use the schemas in the server, including the TypeOf<schema> type, as before
When creating the HTTP request in the client, use KbnConfigSchemaInputTypeOf<schema> type. This type represents the valid inputs to the request.

With this pattern, if the schema changes, the developer will also be notified that the code creating the request needs to be changed.

Gotchas and stuff

The TypeOf type already exists and represents the validated and coerced type of the input. Why can't we use that in the client?

The inputs are more permissive than the validated types due to coercion. For example, the schema schema.number() accepts strings, and will automatically convert these to numbers.

Another reason: the TypeOf type has limited handling of the schema.maybe schema when used with schema.object

const s = schema.object({
  a: schema.maybe(schema.number()),
  b: schema.number()
})
// This should be fine, as 'a' is 'maybe', but `TypeOf` doesn't treat the key as optional.
const input: TypeOf<s> = { 
  b: 1
}
// This is what you'd have to do
const input2: TypeOf<s> = { 
  b: 1,
  a: undefined,
}

Checklist

Delete any items that are not applicable to this PR.

(https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

jonathan-buttner · 2020-03-04T18:00:25Z

x-pack/plugins/endpoint/common/types.ts

@@ -5,6 +5,11 @@
 */

 import { SearchResponse } from 'elasticsearch';
+import { schema, TypeOf } from '@kbn/config-schema';


Not about your code changes but should we break up the types.ts file into smaller files specific to an API like:
A file for alerts, resolver, metadata and then have an index.ts file that puts them altogether so this types.ts file doesn't get too large?

agree. i figure if this PR is well accepted we can do that before merging

jonathan-buttner · 2020-03-04T18:06:17Z

Also I think there is an outstanding issue with using @kbn-config/schema in the browser: #57726

jonathan-buttner · 2020-03-04T18:10:29Z

I believe @jfsiii ran into this too and as a temporary measure had to define TS types (the type XType = TypeOf) to use in the frontend.

joshdover · 2020-03-04T18:19:06Z

Yes I don't believe this is going to work correctly until either #57726 is fixed or we upgrade to TypeScript 3.8 (#57774) and can start using type-only imports.

I believe the underlying problem is that when we import @kbn/config-schema into a client bundle, it drags with it a bunch of server code that doesn't work in the browser. I don't know of a way around this without one of these two fixes.

oatkiller · 2020-03-04T18:27:42Z

@jonathan-buttner @joshdover thanks for the info. I wasn't aware of those issues. I'm also not experiencing any problems with this PR.

Thinking through this: maybe this PR works because the client only imports types and any other @kbn/config-schema stuff is shaken off?

Also, to clarify, this code does not use @kbn/config-schema in the client, just the types derived from it.

oatkiller · 2020-03-04T18:31:49Z

src/core/public/http/types.ts

@@ -205,7 +205,12 @@ export interface HttpRequestInit {

 /** @public */
 export interface HttpFetchQuery {
-  [key: string]: string | number | boolean | undefined;
+  [key: string]:


The underlying code supports this already. This change loosens up the type

jonathan-buttner · 2020-03-04T18:38:12Z

@jonathan-buttner @joshdover thanks for the info. I wasn't aware of those issues. I'm also not experiencing any problems with this PR.

Thinking through this: maybe this PR works because the client only imports types and any other @kbn/config-schema stuff is shaken off?

Also, to clarify, this code does not use @kbn/config-schema in the client, just the types derived from it.

Ah ok, I missed that, that might work then since it's just doing the types and not the @kbn/config-schema itself. I think the issue I saw when testing some code that had the schema imported in the frontend was a reference to a net package was missing. The bootup of kibana wouldn't fail though, it would just print out in the kibana logs and when you browsed to the app page it would fail I think.

joshdover · 2020-03-04T18:49:23Z

@jonathan-buttner @joshdover thanks for the info. I wasn't aware of those issues. I'm also not experiencing any problems with this PR.

Thinking through this: maybe this PR works because the client only imports types and any other @kbn/config-schema stuff is shaken off?

Also, to clarify, this code does not use @kbn/config-schema in the client, just the types derived from it.

Hmm I'm skeptical, because from my understanding this is not how things currently work. If you're importing a module, even just to get the types, that module's dependencies must also be imported & bundled. This is why the type-only imports and exports feature was added to TypeScript.

If this is working, I would like to understand why.

oatkiller · 2020-03-04T18:31:57Z

src/core/public/public.api.md

@@ -610,7 +610,7 @@ export interface HttpFetchOptionsWithPath extends HttpFetchOptions {
 // @public (undocumented)
 export interface HttpFetchQuery {
    // (undocumented)
-    [key: string]: string | number | boolean | undefined;
+    [key: string]: string | number | boolean | undefined | Array<string | number | boolean | undefined>;


generated docs

oatkiller · 2020-03-04T18:32:22Z

x-pack/plugins/endpoint/common/types.ts

+/**
+ * Used to validate GET requests against the index of the alerting APIs.
+ */
+export const alertingIndexGetQuerySchema = schema.object(


If we go w/ this design, the schemas would be centralized in common somewhere. I think

oatkiller · 2020-03-04T18:32:47Z

x-pack/plugins/endpoint/common/types.ts

+    ),
+    sort: schema.maybe(schema.string()),
+    order: schema.maybe(
+      schema.string({


Unrelated to this PR, but I think we could use a oneOf type thing here?

oatkiller · 2020-03-04T19:07:57Z

x-pack/plugins/endpoint/common/types.ts

+type KbnConfigSchemaInputObjectTypeOf<
+  T extends kbnConfigSchemaTypes.ObjectType
+> = T extends kbnConfigSchemaTypes.ObjectType<infer P>
+  ? {


This maps the properties of a schema object. It does it twice, once for values that accept 'undefined', and once for keys that do not. If a value accepts undefined, they key is marked optional (?)
TODO add above in comment in code

oatkiller · 2020-03-04T19:08:49Z

x-pack/plugins/endpoint/public/applications/endpoint/store/alerts/middleware.ts


 export const alertMiddlewareFactory: MiddlewareFactory<AlertListState> = coreStart => {
  return api => next => async (action: AppAction) => {
    next(action);
    const state = api.getState();
    if (action.type === 'userChangedUrl' && isOnAlertPage(state)) {
      const response: AlertResultList = await coreStart.http.get(`/api/endpoint/alerts`, {
-        query: apiQueryParams(state),
+        query: cloneHttpFetchQuery(apiQueryParams(state)),


The http.get function won't accept our Immutable type. I'm not sure if this is the best approach long term.
Basically, we require that the return value of apiQueryParams not be modified, and .get isn't promising that it won't modify them. Therefore we clone it.

Seems okay to me.

oatkiller · 2020-03-04T19:09:09Z

x-pack/plugins/endpoint/public/common/clone_http_fetch_query.ts

+
+import { HttpFetchQuery } from '../../../../../src/core/public';
+
+export function cloneHttpFetchQuery(query: Immutable<HttpFetchQuery>): HttpFetchQuery {


simply clone a query object.

oatkiller · 2020-03-04T19:21:30Z

@jonathan-buttner @joshdover thanks for the info. I wasn't aware of those issues. I'm also not experiencing any problems with this PR.
Thinking through this: maybe this PR works because the client only imports types and any other @kbn/config-schema stuff is shaken off?
Also, to clarify, this code does not use @kbn/config-schema in the client, just the types derived from it.

Hmm I'm skeptical, because from my understanding this is not how things currently work. If you're importing a module, even just to get the types, that module's dependencies must also be imported & bundled. This is why the type-only imports and exports feature was added to TypeScript.

If this is working, I would like to understand why.

@joshdover I don't really know. If i had to guess I'd just say 'tree-shaking?'. But I can dig into it more.

joshdover · 2020-03-04T21:13:27Z

Tree-shaking seems to be the answer. I ran webpack with the stats.json output to use with webpack-bundle-analyzer. What I found is that if you import only types from a module, then the module does not end up in the bundle.

As soon as a value is imported, the entire module and it's dependencies will also be imported into the bundle, causing a break. So it appears this will work as long as the module does not contain any values that also need to be imported.

Either way, CI / optimizer will let you know when this happens if one of the dependencies needed is not supported in the browser (like the net module that Joi depends on).

jfsiii · 2020-03-04T22:24:25Z

@oatkiller @joshdover #59340 (comment) matches my experience as well. Ingest Manager was able to use the TypeOf<typeof SomeKBNConfigSchema>> approach in common/types/ for a few weeks until our client side bundle mysteriously failed with that net error. Our guess was that it was when we added enums which result in a JS object unlike type, interface, etch which are compiled away.

We put the @kbn/config-schema items under server/types/ and are following #57726 & #57774

oatkiller · 2020-03-05T16:34:43Z

@oatkiller @joshdover #59340 (comment) matches my experience as well. Ingest Manager was able to use the TypeOf<typeof SomeKBNConfigSchema>> approach in common/types/ for a few weeks until our client side bundle mysteriously failed with that net error. Our guess was that it was when we added enums which result in a JS object unlike type, interface, etch which are compiled away.

We put the @kbn/config-schema items under server/types/ and are following #57726 & #57774

Thanks for the info. I'm thinking of going w/ the approach I have here in light of the fact that config-schema will likely eventually work in the client. Thanks again

oatkiller · 2020-03-05T16:48:36Z

x-pack/plugins/endpoint/common/types.ts

+> = T extends kbnConfigSchemaTypes.ObjectType
+  ? KbnConfigSchemaInputObjectTypeOf<
+      T
+    > /** The schema.number() schema accepts strings, so accept them here to. There's no good way to make this happen ONLY when schema.number is called? i dont think it matters? */


improve comment verbiage

Typo: to should be too.

I thiiiiink this won't matter if strings are accepted everywhere. That's probably due to the fact that URL query params (which are always strings) are accepted?

madirey · 2020-03-05T17:04:45Z

x-pack/plugins/endpoint/common/types.ts

-  asc = 'asc',
-  desc = 'desc',
-}
+export type Direction = 'asc' | 'desc';


@oatkiller Is type better than enum? TypeScript n00b here.

Other plugins have used enum for this... for example, siem. So just curious what the advantages/disadvantages are.

I didn't have a strong reason for changing this, was just getting around some quick type errors. Let me try and put it back.

That being said, here's what I know about the diff between a union type and an enum:
https://www.typescriptlang.org/play/#code/PTAEGECcFMEMBdoGdS1JArgO3gSwLbSgBusANhtAHQBQ0WG+oAIrjAMZ4D2WoA3jVBDUSdqAC8oAIwAaUCFABPLhlDtYvdgAsNAcyLwtRTDgJFSFIgHdgXNTqy7cj0IYOKADtEHCAJsjFJAHJ1eCQgmgBfGhoFAFFIWCRoX1R4dGw8QloFXAAzJRVQKw1EVPg7JC8yMlAgpPYgkTqG+l9nXSayBGhIGViweE9kYpUyVLzYXFqNVOUMINSsaBTXOxgPbvYiclrnJHgNbaQB0Gc1Ln8aIa8WNmhOXB4AQTIkO2CGpoAfOv9RCKxABUQMEQNAAElQEDDM4ANbg+iMUYYcagABGRF0XEuoDyXEgoAOGDyBTIuDhRHRzlgkEUoCMsH8kBO0OKWlw2lQMFAWC46Ss0BqoDhfKsWFobIAmkV1Lx8LAPKAPDBkukLJQUBUhFhYIRysMULNQBhkq4jPhJeCIeloKSHnhiEL6Zj2FxCEblRtIFxju9IABaA6KMhEN1YA6lK3AGLAEGgMGgADK9DwyzeJuSqXObgZcGZoC4BTQTgKeWm0AAXGCY0imABxfIp0zplACIQKZ68AiwfSgAAUzngPt8GG2qXR9IADAAPABM4DkGlAzyT4AhULd+AVdRkQQAlD4e33gnv+j5O7xoDPEBGnrx0WRfXCB0OR2PVpPQLO57IL2Bl1XdcoWvdhugVbheA8LghzqABCA8fGvW8kHvAAhJ92BfYIEPPDswAAFSMVxEgrQl+zQVDHFDDFFEQQsCg1IhZwAZjQpdeCAjciWgfBOS4J9eCCABuA9+nw9lOS0IktDGCcDGI7oDlo+ii3NIhy1DSUSKmUNCWCUS8PkMBjyIf52EgXAPAqSAjwVfRmACSzrIJCQ6h-cAgiM3J7KIKQpynUB8AJIg1LcZIoiAA

The tl;dr is: enum's end up in the runtime. I think they're good for giving names to magic numbers that you use for data interchange, e.g. binary header sentinels, status codes, etc.

so i tried to go back and make everything the enum, but it turns out we have a whole lot of places in the app writing 'asc' and 'desc' as literals. I don't honestly know what the best practice is, but for the sake of keeping the (runtime) enum out of the validation that will be used on FE and BE, I'm going to keep this as a type for now. I'm aware that this may not be right, I just don't have quite enough experience w/ this yet.

Nah, that's fine. I imagine that could be difficult to work into the schema validation. Let's come back to it later.

madirey · 2020-03-05T17:12:02Z

x-pack/plugins/endpoint/common/types.ts

+/**
+ * Like TypeOf, but provides a type for creating the value that will match.
+ * schema.number accepts a string, so this allows strings for number
+ * schema.maybe creates an optional type, if such a type is a prop on an schema.object,


Is it technically accurate to say "optional type" here? I see that it's clarified on the line below, but this comment seems a little ambiguous.

reworded. Hopefully more clear?

/** * Takes a @kbn/config-schema 'schema' type and returns a type that represents valid inputs. * Similar to `TypeOf`, but allows strings as input for `schema.number()` (which is inline * with the behavior of the validator.) Also, for `schema.object`, when a value is a `schema.maybe` * the key will be marked optional (via `?`) so that you can omit keys for optional values. * * Use this when creating a value that will be passed to the schema. * e.g. * ```ts * const input: KbnConfigSchemaInputTypeOf<typeof schema> = value * schema.validate(input) // should be valid * ``` */

madirey · 2020-03-05T17:13:40Z

x-pack/plugins/endpoint/common/types.ts

+/**
+ * Query params to pass to the alert API when fetching new data.
+ */
+export type AlertingIndexGetQueryInput = KbnConfigSchemaInputTypeOf<


👏 👏 👏

madirey · 2020-03-05T17:15:44Z

x-pack/plugins/endpoint/server/routes/alerts/details/lib/pagination.ts

@@ -39,11 +34,11 @@ export class AlertDetailsPagination extends Pagination<
  ): Promise<SearchResponse<AlertEvent>> {
    const reqData: AlertSearchQuery = {
      pageSize: 1,
-      sort: EndpointAppConstants.ALERT_LIST_DEFAULT_SORT,


can restore it. the value in the constants class was not typed right so i just used the literal

restored it

This reverts commit 5d40ca1.

elasticmachine · 2020-03-06T19:21:03Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

joshdover

Platform changes LGTM

oatkiller · 2020-03-09T15:30:04Z

@elasticmachine merge upstream

kibanamachine · 2020-03-09T17:16:36Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 513dbe0
Flaky suites:
- xpack-kibana-ciGroup9

Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack Saved Object API Integration Tests -- security_only.x-pack/test/saved_object_api_integration/security_only/apis/bulk_update·ts.saved objects security only enabled bulkUpdate dual-privileges user "before all" hook for "should return 403 for hiddentype doc"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/58919
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/58919

[00:00:00]       │
[00:00:00]         └-: saved objects security only enabled
[00:00:00]           └-> "before all" hook
[00:00:00]           └-> "before all" hook
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_legacy_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_dual_privileges_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_dual_privileges_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_default_space_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_default_space_read_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_space_1_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_space_1_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [not_a_kibana_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_legacy_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_dual_privileges_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_dual_privileges_dashboard_only_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_dashboard_only_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_default_space_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_default_space_read_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_space_1_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_space_1_read_user]
[00:05:09]               │ERROR [migrate saved objects] request failed (attempt=5/5)
[00:05:09]               └- ✖ fail: "saved objects security only enabled bulkUpdate dual-privileges user "before all" hook for "should return 403 for hiddentype doc""
[00:05:09]               │
[00:04:49]           └-: bulkUpdate
[00:04:49]             └-> "before all" hook
[00:05:09]                 └-> "after all" hook
[00:04:59]             └-: dual-privileges user
[00:04:59]               └-> "before all" hook
[00:04:59]               └-> "before all" hook
[00:04:59]                 │ info [saved_objects/spaces] Loading "mappings.json"
[00:04:59]                 │ info [saved_objects/spaces] Loading "data.json"
[00:04:59]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:04:59]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana][0]]]).
[00:04:59]                 │ info [r.suppressed] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] path: /.kibana/_doc/telemetry%3Atelemetry, params: {index=.kibana, id=telemetry:telemetry}
[00:04:59]                 │      org.elasticsearch.action.NoShardAvailableActionException: No shard available for [get [.kibana][telemetry:telemetry]: routing [null]]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction.perform(TransportSingleShardAction.java:224) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction.onFailure(TransportSingleShardAction.java:210) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction$2.handleException(TransportSingleShardAction.java:266) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$ContextRestoreResponseHandler.handleException(TransportService.java:1067) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$DirectResponseChannel.processException(TransportService.java:1176) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$DirectResponseChannel.sendResponse(TransportService.java:1150) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TaskTransportChannel.sendResponse(TaskTransportChannel.java:60) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.ChannelActionListener.onFailure(ChannelActionListener.java:56) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable.onFailure(ActionRunnable.java:88) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.onFailure(ThreadContext.java:676) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:39) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
[00:04:59]                 │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
[00:04:59]                 │      	at java.lang.Thread.run(Thread.java:830) [?:?]
[00:04:59]                 │      Caused by: org.elasticsearch.transport.RemoteTransportException: [kibana-ci-immutable-debian-tests-xl-1583767884413211985][127.0.0.1:6193][indices:data/read/get[s]]
[00:04:59]                 │      Caused by: org.elasticsearch.index.shard.IllegalIndexShardStateException: CurrentState[RECOVERING] operations only allowed when shard state is one of [POST_RECOVERY, STARTED]
[00:04:59]                 │      	at org.elasticsearch.index.shard.IndexShard.readAllowed(IndexShard.java:1685) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.shard.IndexShard.get(IndexShard.java:905) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.innerGet(ShardGetService.java:174) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.get(ShardGetService.java:104) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.get(ShardGetService.java:95) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.get.TransportGetAction.shardOperation(TransportGetAction.java:106) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.get.TransportGetAction.shardOperation(TransportGetAction.java:45) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction.lambda$asyncShardOperation$0(TransportSingleShardAction.java:110) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable.lambda$supply$0(ActionRunnable.java:58) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable$2.doRun(ActionRunnable.java:73) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:688) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:37) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	... 3 more
[00:04:59]                 │ info [saved_objects/spaces] Created index ".kibana"
[00:04:59]                 │ debg [saved_objects/spaces] ".kibana" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:04:59]                 │ proc [kibana] internal/process/warning.js:153
[00:04:59]                 │ proc [kibana]         throw warning;
[00:04:59]                 │ proc [kibana]         ^
[00:04:59]                 │ proc [kibana] 
[00:04:59]                 │ proc [kibana] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[00:04:59]                 │ proc [kibana]     at emitDeprecationWarning (internal/process/promises.js:111:13)
[00:04:59]                 │ proc [kibana]     at emitWarning (internal/process/promises.js:104:3)
[00:04:59]                 │ proc [kibana]     at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
[00:04:59]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:69:34)
[00:04:59]                 │ info [saved_objects/spaces] Indexed 16 docs into ".kibana"
[00:04:59]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] [.kibana/J16fJrWzT7GVlK5jLKScwQ] update_mapping [_doc]
[00:04:59]                 └- ✖ fail: "saved objects security only enabled bulkUpdate dual-privileges user "before all" hook"
[00:04:59]                 │
[00:04:59]                 └-> "after all" hook
[00:04:59]                   │ debg Migrating saved objects
[00:04:59]                   │ERROR [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=1/5)
[00:04:59]                   │ERROR [migrate saved objects] request failed (attempt=1/5)
[00:05:00]                   │ERROR [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=2/5)
[00:05:00]                   │ERROR [migrate saved objects] request failed (attempt=2/5)
[00:05:02]                   │ERROR [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=3/5)
[00:05:02]                   │ERROR [migrate saved objects] request failed (attempt=3/5)
[00:05:05]                   │ERROR [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=4/5)
[00:05:05]                   │ERROR [migrate saved objects] request failed (attempt=4/5)
[00:05:09]                   │ERROR [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=5/5)
[00:05:09]                   └- ✖ fail: "saved objects security only enabled bulkUpdate dual-privileges user "after all" hook for "should return 403 for hiddentype doc""
[00:05:09]                   │

Stack Trace

{ DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    at emitDeprecationWarning (internal/process/promises.js:111:13)
    at emitWarning (internal/process/promises.js:104:3)
    at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
    at process._tickCallback (internal/process/next_tick.js:69:34)
  name: 'DeprecationWarning',
  code: 'DEP0018',
  uncaught: true,
  multiple:
   [ Error: [migrate saved objects] request failed (attempt=5/5) -- and ran out of retries
         at KbnClientRequester.request (/dev/shm/workspace/kibana/packages/kbn-dev-utils/target/kbn_client/kbn_client_requester.js:99:23)
         at process._tickCallback (internal/process/next_tick.js:68:7) ] }

Kibana Pipeline / kibana-xpack-agent / X-Pack Saved Object API Integration Tests -- security_only.x-pack/test/saved_object_api_integration/security_only/apis/bulk_update·ts.saved objects security only enabled bulkUpdate dual-privileges user "after all" hook for "should return 403 for hiddentype doc"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/58918

[00:00:00]       │
[00:00:00]         └-: saved objects security only enabled
[00:00:00]           └-> "before all" hook
[00:00:00]           └-> "before all" hook
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_legacy_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_dual_privileges_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_dual_privileges_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_default_space_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_default_space_read_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_space_1_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_space_1_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [not_a_kibana_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_legacy_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_dual_privileges_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_dual_privileges_dashboard_only_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_dashboard_only_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_default_space_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_default_space_read_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_space_1_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_space_1_read_user]
[00:04:49]           └-: bulkUpdate
[00:04:49]             └-> "before all" hook
[00:04:59]             └-: dual-privileges user
[00:04:59]               └-> "before all" hook
[00:04:59]               └-> "before all" hook
[00:04:59]                 │ info [saved_objects/spaces] Loading "mappings.json"
[00:04:59]                 │ info [saved_objects/spaces] Loading "data.json"
[00:04:59]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:04:59]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana][0]]]).
[00:04:59]                 │ info [r.suppressed] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] path: /.kibana/_doc/telemetry%3Atelemetry, params: {index=.kibana, id=telemetry:telemetry}
[00:04:59]                 │      org.elasticsearch.action.NoShardAvailableActionException: No shard available for [get [.kibana][telemetry:telemetry]: routing [null]]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction.perform(TransportSingleShardAction.java:224) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction.onFailure(TransportSingleShardAction.java:210) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction$2.handleException(TransportSingleShardAction.java:266) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$ContextRestoreResponseHandler.handleException(TransportService.java:1067) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$DirectResponseChannel.processException(TransportService.java:1176) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$DirectResponseChannel.sendResponse(TransportService.java:1150) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TaskTransportChannel.sendResponse(TaskTransportChannel.java:60) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.ChannelActionListener.onFailure(ChannelActionListener.java:56) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable.onFailure(ActionRunnable.java:88) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.onFailure(ThreadContext.java:676) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:39) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
[00:04:59]                 │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
[00:04:59]                 │      	at java.lang.Thread.run(Thread.java:830) [?:?]
[00:04:59]                 │      Caused by: org.elasticsearch.transport.RemoteTransportException: [kibana-ci-immutable-debian-tests-xl-1583767884413211985][127.0.0.1:6193][indices:data/read/get[s]]
[00:04:59]                 │      Caused by: org.elasticsearch.index.shard.IllegalIndexShardStateException: CurrentState[RECOVERING] operations only allowed when shard state is one of [POST_RECOVERY, STARTED]
[00:04:59]                 │      	at org.elasticsearch.index.shard.IndexShard.readAllowed(IndexShard.java:1685) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.shard.IndexShard.get(IndexShard.java:905) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.innerGet(ShardGetService.java:174) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.get(ShardGetService.java:104) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.get(ShardGetService.java:95) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.get.TransportGetAction.shardOperation(TransportGetAction.java:106) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.get.TransportGetAction.shardOperation(TransportGetAction.java:45) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction.lambda$asyncShardOperation$0(TransportSingleShardAction.java:110) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable.lambda$supply$0(ActionRunnable.java:58) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable$2.doRun(ActionRunnable.java:73) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:688) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:37) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	... 3 more
[00:04:59]                 │ info [saved_objects/spaces] Created index ".kibana"
[00:04:59]                 │ debg [saved_objects/spaces] ".kibana" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:04:59]                 │ proc [kibana] internal/process/warning.js:153
[00:04:59]                 │ proc [kibana]         throw warning;
[00:04:59]                 │ proc [kibana]         ^
[00:04:59]                 │ proc [kibana] 
[00:04:59]                 │ proc [kibana] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[00:04:59]                 │ proc [kibana]     at emitDeprecationWarning (internal/process/promises.js:111:13)
[00:04:59]                 │ proc [kibana]     at emitWarning (internal/process/promises.js:104:3)
[00:04:59]                 │ proc [kibana]     at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
[00:04:59]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:69:34)
[00:04:59]                 │ info [saved_objects/spaces] Indexed 16 docs into ".kibana"
[00:04:59]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] [.kibana/J16fJrWzT7GVlK5jLKScwQ] update_mapping [_doc]
[00:04:59]                 └- ✖ fail: "saved objects security only enabled bulkUpdate dual-privileges user "before all" hook"
[00:04:59]                 │
[00:04:59]                 └-> "after all" hook
[00:04:59]                   │ debg Migrating saved objects
[00:04:59]                   │ERROR [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=1/5)
[00:04:59]                   │ERROR [migrate saved objects] request failed (attempt=1/5)
[00:05:00]                   │ERROR [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=2/5)
[00:05:00]                   │ERROR [migrate saved objects] request failed (attempt=2/5)
[00:05:02]                   │ERROR [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=3/5)
[00:05:02]                   │ERROR [migrate saved objects] request failed (attempt=3/5)
[00:05:05]                   │ERROR [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=4/5)
[00:05:05]                   │ERROR [migrate saved objects] request failed (attempt=4/5)
[00:05:09]                   │ERROR [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=5/5)
[00:05:09]                   └- ✖ fail: "saved objects security only enabled bulkUpdate dual-privileges user "after all" hook for "should return 403 for hiddentype doc""
[00:05:09]                   │

Stack Trace

Error: [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=5/5) -- and ran out of retries
    at KbnClientRequester.request (/dev/shm/workspace/kibana/packages/kbn-dev-utils/target/kbn_client/kbn_client_requester.js:99:23)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / kibana-xpack-agent / X-Pack Saved Object API Integration Tests -- security_only.x-pack/test/saved_object_api_integration/security_only/apis/bulk_update·ts.saved objects security only enabled bulkUpdate dual-privileges user "before all" hook for "should return 403 for hiddentype doc"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/58919
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/58919

[00:00:00]       │
[00:00:00]         └-: saved objects security only enabled
[00:00:00]           └-> "before all" hook
[00:00:00]           └-> "before all" hook
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_legacy_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_dual_privileges_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_dual_privileges_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_default_space_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_default_space_read_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_space_1_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added role [kibana_rbac_space_1_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [not_a_kibana_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_legacy_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_dual_privileges_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_dual_privileges_dashboard_only_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_dashboard_only_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_default_space_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_default_space_read_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_space_1_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] added user [a_kibana_rbac_space_1_read_user]
[00:05:09]               │ERROR [migrate saved objects] request failed (attempt=5/5)
[00:05:09]               └- ✖ fail: "saved objects security only enabled bulkUpdate dual-privileges user "before all" hook for "should return 403 for hiddentype doc""
[00:05:09]               │
[00:04:49]           └-: bulkUpdate
[00:04:49]             └-> "before all" hook
[00:05:09]                 └-> "after all" hook
[00:04:59]             └-: dual-privileges user
[00:04:59]               └-> "before all" hook
[00:04:59]               └-> "before all" hook
[00:04:59]                 │ info [saved_objects/spaces] Loading "mappings.json"
[00:04:59]                 │ info [saved_objects/spaces] Loading "data.json"
[00:04:59]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:04:59]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana][0]]]).
[00:04:59]                 │ info [r.suppressed] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] path: /.kibana/_doc/telemetry%3Atelemetry, params: {index=.kibana, id=telemetry:telemetry}
[00:04:59]                 │      org.elasticsearch.action.NoShardAvailableActionException: No shard available for [get [.kibana][telemetry:telemetry]: routing [null]]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction.perform(TransportSingleShardAction.java:224) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction.onFailure(TransportSingleShardAction.java:210) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction$2.handleException(TransportSingleShardAction.java:266) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$ContextRestoreResponseHandler.handleException(TransportService.java:1067) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$DirectResponseChannel.processException(TransportService.java:1176) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$DirectResponseChannel.sendResponse(TransportService.java:1150) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TaskTransportChannel.sendResponse(TaskTransportChannel.java:60) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.ChannelActionListener.onFailure(ChannelActionListener.java:56) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable.onFailure(ActionRunnable.java:88) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.onFailure(ThreadContext.java:676) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:39) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
[00:04:59]                 │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
[00:04:59]                 │      	at java.lang.Thread.run(Thread.java:830) [?:?]
[00:04:59]                 │      Caused by: org.elasticsearch.transport.RemoteTransportException: [kibana-ci-immutable-debian-tests-xl-1583767884413211985][127.0.0.1:6193][indices:data/read/get[s]]
[00:04:59]                 │      Caused by: org.elasticsearch.index.shard.IllegalIndexShardStateException: CurrentState[RECOVERING] operations only allowed when shard state is one of [POST_RECOVERY, STARTED]
[00:04:59]                 │      	at org.elasticsearch.index.shard.IndexShard.readAllowed(IndexShard.java:1685) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.shard.IndexShard.get(IndexShard.java:905) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.innerGet(ShardGetService.java:174) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.get(ShardGetService.java:104) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.get(ShardGetService.java:95) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.get.TransportGetAction.shardOperation(TransportGetAction.java:106) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.get.TransportGetAction.shardOperation(TransportGetAction.java:45) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction.lambda$asyncShardOperation$0(TransportSingleShardAction.java:110) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable.lambda$supply$0(ActionRunnable.java:58) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable$2.doRun(ActionRunnable.java:73) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:688) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:37) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	... 3 more
[00:04:59]                 │ info [saved_objects/spaces] Created index ".kibana"
[00:04:59]                 │ debg [saved_objects/spaces] ".kibana" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:04:59]                 │ proc [kibana] internal/process/warning.js:153
[00:04:59]                 │ proc [kibana]         throw warning;
[00:04:59]                 │ proc [kibana]         ^
[00:04:59]                 │ proc [kibana] 
[00:04:59]                 │ proc [kibana] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[00:04:59]                 │ proc [kibana]     at emitDeprecationWarning (internal/process/promises.js:111:13)
[00:04:59]                 │ proc [kibana]     at emitWarning (internal/process/promises.js:104:3)
[00:04:59]                 │ proc [kibana]     at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
[00:04:59]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:69:34)
[00:04:59]                 │ info [saved_objects/spaces] Indexed 16 docs into ".kibana"
[00:04:59]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1583767884413211985] [.kibana/J16fJrWzT7GVlK5jLKScwQ] update_mapping [_doc]
[00:04:59]                 └- ✖ fail: "saved objects security only enabled bulkUpdate dual-privileges user "before all" hook"
[00:04:59]                 │
[00:04:59]                 └-> "after all" hook
[00:04:59]                   │ debg Migrating saved objects
[00:04:59]                   │ERROR [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=1/5)
[00:04:59]                   │ERROR [migrate saved objects] request failed (attempt=1/5)
[00:05:00]                   │ERROR [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=2/5)
[00:05:00]                   │ERROR [migrate saved objects] request failed (attempt=2/5)
[00:05:02]                   │ERROR [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=3/5)
[00:05:02]                   │ERROR [migrate saved objects] request failed (attempt=3/5)
[00:05:05]                   │ERROR [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=4/5)
[00:05:05]                   │ERROR [migrate saved objects] request failed (attempt=4/5)
[00:05:09]                   │ERROR [GET http://elastic:changeme@localhost:6191/api/status] request failed (attempt=5/5)
[00:05:09]                   └- ✖ fail: "saved objects security only enabled bulkUpdate dual-privileges user "after all" hook for "should return 403 for hiddentype doc""
[00:05:09]                   │

Stack Trace

Error: [migrate saved objects] request failed (attempt=5/5) -- and ran out of retries
    at KbnClientRequester.request (/dev/shm/workspace/kibana/packages/kbn-dev-utils/target/kbn_client/kbn_client_requester.js:99:23)
    at process._tickCallback (internal/process/next_tick.js:68:7)

History

💚 Build #31507 succeeded a25663f
💔 Build #31211 failed a294971
💔 Build #30889 failed eac4bff
💚 Build #30831 succeeded 69f551b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (22 commits) Generate docs from data plugin (elastic#56955) Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514) Harden creation of child processes (elastic#55697) [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475) [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553) chore: 🤖 hide Drilldowns in master (elastic#59698) [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175) Use HTTP request schemas to create types, use those types in the client (elastic#59340) [Maps] Support categorical styling for numbers and dates (elastic#57908) [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665) Fix slm_ui setting by changing camel case back to snake case. (elastic#59663) removes beta tag (elastic#59618) [DOCS] Removed spatial references (elastic#59595) fix outdated docs (elastic#58729) [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639) [ML] Refactoring anomaly detector job types (elastic#59556) [Upgrade Assistant] Better handling of closed indices (elastic#58890) additional visualizations plugin cleanup before moving to NP (elastic#59318) In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285) [Visualize] Remove global state in visualize (elastic#58352) ...

…s/kibana into alerting/fix-flaky-instance-test * 'alerting/fix-flaky-instance-test' of github.com:gmmorris/kibana: (176 commits) Generate docs from data plugin (elastic#56955) Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514) Harden creation of child processes (elastic#55697) [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475) [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553) chore: 🤖 hide Drilldowns in master (elastic#59698) [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175) Use HTTP request schemas to create types, use those types in the client (elastic#59340) [Maps] Support categorical styling for numbers and dates (elastic#57908) [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665) Fix slm_ui setting by changing camel case back to snake case. (elastic#59663) removes beta tag (elastic#59618) [DOCS] Removed spatial references (elastic#59595) fix outdated docs (elastic#58729) [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639) [ML] Refactoring anomaly detector job types (elastic#59556) [Upgrade Assistant] Better handling of closed indices (elastic#58890) additional visualizations plugin cleanup before moving to NP (elastic#59318) In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285) [Visualize] Remove global state in visualize (elastic#58352) ...

kibanamachine · 2020-03-10T17:28:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59340 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-03-11T17:38:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59340 or prevent reminders by adding the backport:skip label.

…nt (#59340) (#59942)

…nt (elastic#59340) * wip * wip * wip * will this work? * wip but it works * pedro * remove thing * remove TODOs * fix type issue * add tests to check that alert index api works * Revert "add tests to check that alert index api works" This reverts commit 5d40ca1. * Moved schema * undoing my evils * fix comments. fix incorrect import Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

oatkiller requested a review from a team as a code owner March 4, 2020 17:42

oatkiller requested review from madirey and paul-tavares March 4, 2020 17:43

jonathan-buttner reviewed Mar 4, 2020

View reviewed changes

oatkiller commented Mar 4, 2020

View reviewed changes

oatkiller commented Mar 5, 2020

View reviewed changes

madirey reviewed Mar 5, 2020

View reviewed changes

oatkiller force-pushed the schema-stuff branch from eac4bff to a294971 Compare March 5, 2020 19:23

oatkiller added 8 commits March 6, 2020 11:30

wip

3142dc7

wip

56cccba

wip

5f4914e

will this work?

372ed2c

wip but it works

7932058

pedro

287a2a5

remove thing

52026d2

remove TODOs

a5a6e79

oatkiller added 4 commits March 6, 2020 11:30

Revert "add tests to check that alert index api works"

21a84e6

This reverts commit 5d40ca1.

Moved schema

07fceb7

undoing my evils

1163eb3

fix comments. fix incorrect import

a25663f

oatkiller force-pushed the schema-stuff branch from a294971 to a25663f Compare March 6, 2020 17:48

oatkiller added Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 labels Mar 6, 2020

dplumlee approved these changes Mar 6, 2020

View reviewed changes

jonathan-buttner approved these changes Mar 6, 2020

View reviewed changes

joshdover approved these changes Mar 8, 2020

View reviewed changes

Merge branch 'master' into schema-stuff

513dbe0

elasticmachine requested a review from a team as a code owner March 9, 2020 15:30

oatkiller merged commit 12a3ccf into elastic:master Mar 9, 2020

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 10, 2020

oatkiller mentioned this pull request Mar 11, 2020

[7.x] Use HTTP request schemas to create types, use those types in the client (#59340) #59942

Merged

oatkiller added a commit that referenced this pull request Mar 11, 2020

Use HTTP request schemas to create types, use those types in the clie…

2545374

…nt (#59340) (#59942)

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 11, 2020

oatkiller mentioned this pull request Mar 11, 2020

Endpoint: Metadata API schema type used in client #59835

Closed

1 task

watson mentioned this pull request Mar 27, 2020

Upgrade Node.js to version 12 #61587

Merged

oatkiller deleted the schema-stuff branch March 31, 2022 11:04


		import { HttpFetchQuery } from '../../../../../src/core/public';

		export function cloneHttpFetchQuery(query: Immutable<HttpFetchQuery>): HttpFetchQuery {

Use HTTP request schemas to create types, use those types in the client #59340

Use HTTP request schemas to create types, use those types in the client #59340

Conversation

oatkiller commented Mar 4, 2020 • edited

Summary

Backstory

Ideas

Gotchas and stuff

Checklist

For maintainers

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonathan-buttner commented Mar 4, 2020

jonathan-buttner commented Mar 4, 2020

joshdover commented Mar 4, 2020

oatkiller commented Mar 4, 2020

Choose a reason for hiding this comment

jonathan-buttner commented Mar 4, 2020

joshdover commented Mar 4, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oatkiller commented Mar 4, 2020

joshdover commented Mar 4, 2020

jfsiii commented Mar 4, 2020

oatkiller commented Mar 5, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oatkiller Mar 5, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Mar 6, 2020

joshdover left a comment

Choose a reason for hiding this comment

oatkiller commented Mar 9, 2020

kibanamachine commented Mar 9, 2020

💛 Build succeeded, but was flaky

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

History

kibanamachine commented Mar 10, 2020

kibanamachine commented Mar 11, 2020

oatkiller commented Mar 4, 2020 •

edited

oatkiller Mar 5, 2020 •

edited