Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downstream dependency service name to logs and errors to improve alert insights #183215

Merged
merged 6 commits into from May 13, 2024

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented May 12, 2024

Related: #183216

Changes

  • Exclude APM error docs from logs and retrieve APM errors separately
  • Get sample trace.id from logs and apm errors, and retrieve the downstream service name (if available)
  • Minor prompt tweaks

Scenario

When running the Otel-Demo the "checkout" service is killed on purpose. This causes the failure rate of the frontend service to increase because is has a downstream dependency on the checkout service. This in turn causes alerts to be triggered.

When the user navigates to the alerts details page, and opens the insights they should be presented with the "checkout" service as the root cause.

Before

Before this change the alert insights did not capture that changes to the checkout service was the root cause

image

After

image

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

}

const downstreamServiceResource = await getDownstreamServiceResource({
traceId: errorGroup.traceId,
Copy link
Member Author

@sorenlouv sorenlouv May 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The downstream service name is resolved via a single sample trace id. The error could have multiple failed downstream dependencies. Ideally we'd get every downstream dependency for the given error. Not sure how in a performant manner

@sorenlouv
Copy link
Member Author

buildkite test this

@sorenlouv sorenlouv marked this pull request as ready for review May 13, 2024 07:02
@sorenlouv sorenlouv requested review from a team as code owners May 13, 2024 07:02
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels May 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 13, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 286.0KB 286.3KB +268.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5407 +5407
total size - 8.8MB +8.8MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit 0fda9c4 into elastic:main May 13, 2024
21 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 13, 2024
@sorenlouv sorenlouv deleted the improve-contextual-alert-insights branch May 13, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:enhancement Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants