Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UII] Allow components to be used for configured settings description #183203

Merged
merged 6 commits into from May 13, 2024

Conversation

jen-huang
Copy link
Contributor

@jen-huang jen-huang commented May 10, 2024

Summary

Spinning out a few unrelated tweaks from the work for #180778. This PR:

  • In addition to strings, allows React components to be used for configured settings description
  • Fixes small i18n issues
  • Fixes some setting names to have sentence casing and adjust some description copies
  • Moves deprecated unenrollment timeout setting to bottom of list

Screenshot with all changes:

image

@jen-huang jen-huang added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.14.0 v8.15.0 labels May 10, 2024
@jen-huang jen-huang self-assigned this May 10, 2024
@jen-huang jen-huang requested a review from a team as a code owner May 10, 2024 22:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jen-huang
Copy link
Contributor Author

@elasticmachine merge upstream

@jen-huang jen-huang enabled auto-merge (squash) May 13, 2024 15:41
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.3MB 1.3MB +139.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

@jen-huang jen-huang merged commit fd101bf into elastic:main May 13, 2024
19 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.14 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 183203

Questions ?

Please refer to the Backport tool documentation

@jen-huang jen-huang deleted the fix/configured-settings-description branch May 14, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants