New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Index Management] Fix mapping_tab error due to _data_stream_timestamp #183187
[Index Management] Fix mapping_tab error due to _data_stream_timestamp #183187
Conversation
@elasticmachine merge upstream |
/ci |
Hi @saikatsarkar056 this change looks good. However, I would like to validate it on a cloud deployment before merging as I'm still a little confused why I saw 2 different types of errors. I want to make sure both are addressed. |
@saikatsarkar056 I verified your change on cloud and everything looks good 👍. I'm going to ask an engineer on my team do the code review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing this, @saikatsarkar056!
Code changes LGTM 👍
I think we are missing an e2e test for the index details page so I'll open an issue to track that.
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
elastic#183187) (cherry picked from commit 3d79d43)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…imestamp (#183187) (#183306) # Backport This will backport the following commits from `main` to `8.14`: - [[Index Management] Fix mapping_tab error due to _data_stream_timestamp (#183187)](#183187) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Saikat Sarkar","email":"132922331+saikatsarkar056@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-05-13T15:15:19Z","message":"[Index Management] Fix mapping_tab error due to _data_stream_timestamp (#183187)","sha":"3d79d4349443608c92ad42b981d5f010921af97f","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:EnterpriseSearch","backport:prev-minor","ci:cloud-deploy","v8.14.0","v8.15.0"],"title":"[Index Management] Fix mapping_tab error due to _data_stream_timestamp","number":183187,"url":"#183187 Management] Fix mapping_tab error due to _data_stream_timestamp (#183187)","sha":"3d79d4349443608c92ad42b981d5f010921af97f"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#183187 Management] Fix mapping_tab error due to _data_stream_timestamp (#183187)","sha":"3d79d4349443608c92ad42b981d5f010921af97f"}}]}] BACKPORT--> Co-authored-by: Saikat Sarkar <132922331+saikatsarkar056@users.noreply.github.com>
An error or warning message is displayed on the index mappings tab when viewing mappings for a backing index. This looks like _data_stream_timestamp is missing in the mappingsConfigurationSchema.
Fixes #183055
Screen-recording after bug-fix
Screen.Recording.2024-05-10.at.11.47.03.AM.mov