Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Node.js 20 #162696
Upgrade to Node.js 20 #162696
Changes from 17 commits
22269e4
65a9dcc
460fba9
08f9411
df06214
c0e5407
c21a456
f051574
d9a4618
bd7ee6e
9bd5429
ad5b821
768402f
9f9635a
01ded6d
93b1096
a4e89c9
d2ea806
89d5706
a9736bf
9621ab0
bb60245
80d5fcd
0ea7991
4acbd1c
4f6bee1
d4295b3
95f4965
5404d0f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really wish we could take the opportunity to refactor this code when it turns out to be flaky so that it doesn't rely on a timer☹️ But maybe that's not easy in this case
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dokmic FYI