Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Storybook to 6.5 #139334

Merged
merged 13 commits into from Sep 23, 2022
Merged

Update Storybook to 6.5 #139334

merged 13 commits into from Sep 23, 2022

Conversation

clintandrewhall
Copy link
Contributor

@clintandrewhall clintandrewhall commented Aug 24, 2022 •
edited

Summary

As titled. I'm working on some documentation upgrades for Shared UX, and would like to use MDX-2 and interaction functionality.

  • Pinned colorette to avoid a yarn install issue when bootstrapping.
  • Followed and applied migration guidance.
  • Removed incorrect addon from Discover, (addon does not exist)
  • Tested each Storybook for startup compatibility.
  • Tested Canvas addon.

@clintandrewhall clintandrewhall added review Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:Storybook Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.5.0 labels Aug 24, 2022
@clintandrewhall clintandrewhall requested a review from a team as a code owner August 24, 2022 03:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@clintandrewhall clintandrewhall requested a review from a team as a code owner August 24, 2022 04:23
kertal
kertal approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discover changes LGTM, storybook is still working, thx for fixing it

@spalger spalger requested a review from a team as a code owner August 24, 2022 17:58
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Aug 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@spalger spalger requested a review from a team as a code owner August 24, 2022 19:19
@clintandrewhall clintandrewhall mentioned this pull request Aug 24, 2022
Closed
smith
smith approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked a few storybooks on CI and they look good. Thanks for the update!

mistic
mistic approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the missing type package on the checkTypes step failure, lgtm

@clintandrewhall
Copy link
Contributor Author

Had a chat with the Storybook team, wrote a PR to address the type check problem. Fix from them pending, and then we'll be clear to ship this.

storybookjs/storybook#19048

@spalger spalger removed their request for review September 12, 2022 16:00
@patrykkopycinski
Copy link
Contributor

@clintandrewhall Thank you for updating storybook! would you mind bumping to the newest version ^6.5.12? as it fixes some compatibility issues with React@18?

@clintandrewhall
Copy link
Contributor Author

@patrykkopycinski Sure thing!

@clintandrewhall
Copy link
Contributor Author

@elasticmachine test this

@clintandrewhall clintandrewhall enabled auto-merge (squash) September 22, 2022 21:37
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1314 1346 +32
canvas 1152 1163 +11
controls 202 207 +5
crossClusterReplication 139 146 +7
dashboard 394 401 +7
enterpriseSearch 1714 1746 +32
fileUpload 206 309 +103
graph 285 294 +9
indexManagement 485 492 +7
infra 1007 1017 +10
ingestPipelines 327 352 +25
lens 905 912 +7
licenseManagement 130 137 +7
maps 990 1019 +29
ml 1622 1626 +4
monitoring 508 518 +10
observability 467 477 +10
presentationUtil 186 193 +7
remoteClusters 122 129 +7
rollup 143 150 +7
securitySolution 3149 3166 +17
synthetics 992 1011 +19
threatIntelligence 205 210 +5
timelines 256 273 +17
total +394

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +14.5KB
canvas 1.0MB 1.0MB +3.5KB
controls 458.6KB 460.2KB +1.6KB
crossClusterReplication 165.5KB 167.9KB +2.4KB
dashboard 387.5KB 390.0KB +2.5KB
enterpriseSearch 1.7MB 1.7MB +8.3KB
fileUpload 851.2KB 907.0KB +55.7KB
graph 450.6KB 453.7KB +3.0KB
home 147.0KB 147.8KB +760.0B
indexManagement 523.0KB 525.4KB +2.4KB
infra 1.0MB 1.0MB +2.8KB
ingestPipelines 430.8KB 436.8KB +6.0KB
lens 1.2MB 1.2MB +2.4KB
licenseManagement 63.4KB 65.8KB +2.4KB
maps 2.6MB 2.7MB +14.2KB
ml 3.4MB 3.4MB +1.0KB
monitoring 479.7KB 482.6KB +2.8KB
observability 522.5KB 525.4KB +2.8KB
presentationUtil 130.5KB 132.9KB +2.4KB
remoteClusters 84.1KB 86.5KB +2.4KB
rollup 131.2KB 133.6KB +2.4KB
securitySolution 6.6MB 6.6MB +2.9KB
synthetics 1021.3KB 1.0MB +5.9KB
threatIntelligence 74.6KB 74.7KB +49.0B
total +145.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 5.0MB 5.0MB +5.2KB
securitySolution 263.5KB 265.9KB +2.4KB
threatIntelligence 28.7KB 30.3KB +1.6KB
timelines 268.7KB 274.0KB +5.2KB
total +14.4KB
Unknown metric groups

API count

id before after diff
@kbn/storybook 38 41 +3

Unreferenced deprecated APIs

id before after diff
@kbn/storybook 0 1 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit 3ef304f into elastic:main Sep 23, 2022
@mistic mistic mentioned this pull request Jun 12, 2023
Closed
Ikuni17 pushed a commit to Ikuni17/kibana that referenced this pull request Jun 21, 2023
@clintandrewhall @kibanamachine @Ikuni17
Update Storybook to 6.5 (elastic#139334)
8d1b63b 
* Update Storybook to 6.5

* Add @types/react-syntax-highlighter

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* fix type error

* include some deduping and patch version bumping to encourage yarn to do the right thing

* fix path to canvas addon

* remove addon build

* fix some type issues

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* 6.5.12

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: spalger <spencer@elastic.co>
@Ikuni17 Ikuni17 mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@kertal kertal kertal approved these changes

@mistic mistic mistic approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Storybook release_note:skip Skip the PR/issue when compiling release notes review Team:APM All issues that need APM UI Team support Team:Operations Team label for Operations Team Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@clintandrewhall @elasticmachine @patrykkopycinski @kibana-ci @smith @sorenlouv @kertal @mistic @ThomThomson @kibanamachine