Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Removing broken data recognizer test #104387

Merged
merged 1 commit into from Jul 7, 2021
Merged

[ML] Removing broken data recognizer test #104387

merged 1 commit into from Jul 7, 2021

Conversation

jgowdyelastic
Copy link
Member

Removes broken test which is looking for the now removed data recognizer cards in the index data visualizer.
Also removes the test skipped here #104042 which allowed this broken test to be merged to master.

@jgowdyelastic jgowdyelastic added review non-issue Indicates to automation that a pull request should not appear in the release notes :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated: Automatically backport this PR after it's merged v7.15.0 labels Jul 6, 2021
@jgowdyelastic jgowdyelastic self-assigned this Jul 6, 2021
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner July 6, 2021 08:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

walterra
walterra approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit d0986c2 into elastic:master Jul 7, 2021
@jgowdyelastic jgowdyelastic deleted the removing-broken-data-recognizer-test branch July 7, 2021 08:00
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2021
@jgowdyelastic @kibanamachine
[ML] Removing broken data recognizer test (elastic#104387)
1650560
@kibanamachine kibanamachine mentioned this pull request Jul 7, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2021
@jgowdyelastic @kibanamachine
[ML] Removing broken data recognizer test (elastic#104387)
e51e4b0
@kibanamachine kibanamachine mentioned this pull request Jul 7, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 7, 2021
@kibanamachine @jgowdyelastic
[ML] Removing broken data recognizer test (#104387) (#104585)
36ef684 
Co-authored-by: James Gowdy <jgowdy@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 7, 2021
@kibanamachine @jgowdyelastic
[ML] Removing broken data recognizer test (#104387) (#104586)
3c5d30f 
Co-authored-by: James Gowdy <jgowdy@elastic.co>
darnautov pushed a commit to darnautov/kibana that referenced this pull request Jul 7, 2021
@jgowdyelastic @darnautov
[ML] Removing broken data recognizer test (elastic#104387)
6008691
@pheyos pheyos mentioned this pull request Jul 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

@pheyos pheyos Awaiting requested review from pheyos

Assignees

@jgowdyelastic jgowdyelastic

Labels
auto-backport Deprecated: Automatically backport this PR after it's merged :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @walterra @peteharverson