New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve BWC distribution mismatch error message #88911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>non-issue
:Delivery/Build
Build or test infrastructure
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
v7.17.6
v8.4.1
labels
Jul 28, 2022
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
reviewed
Jul 28, 2022
...rnal/src/main/java/org/elasticsearch/gradle/internal/InternalDistributionBwcSetupPlugin.java
Outdated
Show resolved
Hide resolved
pugnascotia
approved these changes
Jul 28, 2022
@elasticmachine update branch |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Aug 22, 2022
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Aug 22, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 22, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
:Delivery/Build
Build or test infrastructure
>non-issue
Team:Delivery
Meta label for Delivery team
v7.17.6
v8.4.1
v8.5.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After version bumps, it's very common for open PR branches to start failing because of the missing version constants breaking BWC distribution assumptions. You end up getting somewhat obscure error that doesn't give you much indication as to the reason things failed:
This PR amends this error message to give developers some hint as to what might be wrong: